cargo-insta cannot find snapshots in non-default directories

[LPGhatguy]

Hi! I just upgraded to insta 0.11 and started taking advantage of the Settings struct to partition my snapshots a little more.

My tests are roughly of this shape:

let mut settings = insta::Settings::new();

let snapshot_path = Path::new(env!("CARGO_MANIFEST_DIR")).join("serve-test-snapshots");
settings.set_snapshot_path(snapshot_path);

settings.bind(|| {
    // Do the actual test

    assert_yaml_snapshot!(info, {
        ".sessionId" => "[session id]"
    });
});

When I get a snapshot failure, the .snap.new file is created in the correct place. The output tells me to run cargo insta review.

I run cargo insta review --all instead because I'm running in a workspace, but Insta tells me I have no snapshots to review:

lgreathouse /c/projects/rojo (master)
$ cargo insta review --all
done: no snapshots to review

...but I know it's lying, since my tests are still failing!

This issue also causes cargo insta test to fail, since it cannot find the snapshots that were just created. This means that the snippet recommended in the changelog to upgrade to 0.11.0 doesn't finish!

[LPGhatguy]

It looks like my snapshots are found if I use --workspace-root, but only if my current working directory is NOT the workspace root.

For example:

lgreathouse /c/projects/rojo (master)
$ cargo insta review --all
done: no snapshots to review

lgreathouse /c/projects/rojo (master)
$ cargo insta review --all --workspace-root .
done: no snapshots to review

lgreathouse /c/projects/rojo (master)
$ cd ..

lgreathouse /c/projects
$ cargo insta review --all --workspace-root rojo
(review UI pops up)

I noticed this because I cloned Insta and started poking at the code to see if I could fix this issue, and the issue magically did not happen when I was testing against master!

[mitsuhiko]

I cannot reproduce this. Should this issue be closed?

[LPGhatguy]

I can try again when I get back into work this week and see if I can get you a minimal reproduction!

[LPGhatguy]

Still happening on the project that this affects. I'll upgrade to Insta 0.12.0 and see if I can get a small repro case.

[mkantor]

Just chiming in to confirm that this does in fact still happen. Here's a repro.

[mkantor]

I tracked the cause down to load_snapshot_containers. Going down the Some branch in that function means that snapshots are only searched for inside the source path of each package, not the workspace root.

[mitsuhiko]

Thanks. Fixed!