cargo-insta: fix --manifest-path <virtual-workspace> #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a good change. A bit of my worry is that we cargo-insta has abysmal test coverage, so I think I would need to do some manual testing on this. |
|
Makes sense to me. I did test this locally. |
Prior to this change --manifest-path only worked properly if it pointed to the root of a non-virtual workspace. Rewrite all the cargo interaction to use cargo-metadata which crucially provides `Metadata::resolve::root` which is used to determine which package --manifest-path was pointing to. https://doc.rust-lang.org/cargo/reference/workspaces.html#virtual-workspace
|
I did find a buglet here in handling a virtual workspace where a manifest path is not specified - it should be fixed now. |
|
@mitsuhiko could you cut a new release please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change --manifest-path only worked properly if it pointed to the root of a non-virtual workspace.
Rewrite all the cargo interaction to use cargo-metadata which crucially provides
Metadata::resolve::rootwhich is used to determine which package --manifest-path was pointing to.https://doc.rust-lang.org/cargo/reference/workspaces.html#virtual-workspace