Pass --color=... to libtest
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two parts to mitsuhiko#367 : - The libtest output, which this PR solves - I've hand-tested it - Possibly this becomes moot if `cargo` is changed to handle more of the output - The `insta` output when insta is called by libtest; e.g. the diffs. There's not much we can do here, but [`CLICOLOR_FORCE`](http://bixense.com/clicolors/) works
max-sixty
added a commit
to max-sixty/prql
that referenced
this pull request
Jun 2, 2023
Based on investigation at mitsuhiko/insta#375
max-sixty
commented
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two parts to #367 :
cargois changed to handle more of the outputinstaoutput when insta is called by libtest; e.g. the diffs. There's not much we can do fromcargo-insta, butCLICOLOR_FORCEworks, becauseconsolereads it