Write inline snapshots with atomic rename #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm occasionally seeing a chunk of the file cut off when using insta with https://dystroy.org/bacon/. This does an atomic rename. It does add a dependency though, so up to you on the tradeoff.
mitsuhiko
requested changes
Jun 3, 2023
|
One aspect to highlight — though this doesn't change the existing behavior — it will overwrite the file even if it's been edited by the user. This can happen when using We could add a check that there has been no change to the file; I do this in https://github.com/max-sixty/pytest-accept. |
mitsuhiko
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm occasionally seeing a chunk of the file cut off when using insta with https://dystroy.org/bacon/, which restarts on any file change. The proposed code does an atomic rename, preventing this.
It does add a dependency though, so up to you on the tradeoff.