Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include line number in cargo insta review #191

Closed
lpil opened this issue Aug 15, 2021 · 2 comments · Fixed by #203
Closed

Include line number in cargo insta review #191

lpil opened this issue Aug 15, 2021 · 2 comments · Fixed by #203

Comments

@lpil
Copy link

lpil commented Aug 15, 2021

Hello! Thank you for this wonderful tool!

When reviewing changes to snapshots I often want to refer to the test that produced them. Currently the review tool prints the source like so:

Reviewing [1/4]:
Package: gleam-core (0.17.0-dev)
Snapshot file: compiler-core/src/javascript/tests/snapshots/gleam_core__javascript__tests__bools__shadowed_bools_and_nil.snap
Snapshot: javascript__tests__bools__shadowed_bools_and_nil
Source: compiler-core/src/javascript/tests/bools.rs

It would be great to have the number number as well as the source file so one could click on it in their editor and see the code used to produce the snapshot.

Thanks again!

@lpil
Copy link
Author

lpil commented Aug 15, 2021

Oh! They started showing up. Not sure what changed.

@lpil lpil closed this as completed Aug 15, 2021
@lpil
Copy link
Author

lpil commented Aug 15, 2021

Ah, I think it is when there are multiple assertions? Would be nice to always have them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant