Proposal: let globs follow links #132
Merged
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkantor
commented
Aug 15, 2020
| @@ -7,6 +7,7 @@ use crate::settings::Settings; | |||
| pub fn glob_exec<F: FnMut(&Path)>(base: &Path, pattern: &str, mut f: F) { | |||
| let walker = GlobWalkerBuilder::new(base, pattern) | |||
| .case_insensitive(true) | |||
| .follow_links(true) | |||
| .file_type(FileType::FILE) | |||
There was a problem hiding this comment.
Tangentially, what's the reason for constraining globs to only match regular files?
I have a project where my inputs for snapshots are directories, not files, and it would be handy to be able to use the glob! macro (right now I loop through them myself).
|
This is a good chance, adding. The main reason to skip over folders was to avoid accidentally encountering stuff that should not be included if you directly open a file. But there are arguments to be made that it should also include directories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would let me be more creative with where I place my input files.