CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to insta and cargo-insta are documented here.
 
+## 1.24.1
+
+- Fix non working `--include-hidden` flag (#331)
+- Fix incorrect mapping of `review.include_ignored` (#330) 
+
 ## 1.24.0
 
 - Added an insta tool config (`.config/insta.yaml`) to change the

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "insta"
-version = "1.24.0"
+version = "1.24.1"
 license = "Apache-2.0"
 authors = ["Armin Ronacher <armin.ronacher@active-4.com>"]
 description = "A snapshot testing library for Rust"

cargo-insta/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cargo-insta"
-version = "1.24.0"
+version = "1.24.1"
 license = "Apache-2.0"
 authors = ["Armin Ronacher <armin.ronacher@active-4.com>"]
 description = "A review tool for the insta snapshot testing library for Rust"
@@ -12,7 +12,7 @@ edition = "2018"
 readme = "README.md"
 
 [dependencies]
-insta = { version = "=1.24.0", path = "..", features = ["json", "yaml", "redactions", "_cargo_insta_internal"] }
+insta = { version = "=1.24.1", path = "..", features = ["json", "yaml", "redactions", "_cargo_insta_internal"] }
 console = "0.15.1"
 structopt = { version = "0.3.26", default-features = false }
 serde = { version = "1.0.117", features = ["derive"] }

cargo-insta/src/cargo.rs

@@ -260,7 +260,9 @@ pub fn find_snapshots<'a>(
 ) -> impl Iterator<Item = Result<SnapshotContainer, Box<dyn Error>>> + 'a {
     let mut builder = WalkBuilder::new(root.clone());
     builder.standard_filters(!flags.include_ignored);
-    if !flags.include_hidden {
+    if flags.include_hidden {
+        builder.hidden(false);
+    } else {
         builder.filter_entry(|e| e.file_type().map_or(false, |x| x.is_file()) || !is_hidden(e));
     }
 

src/env.rs

@@ -233,7 +233,7 @@ impl ToolConfig {
                 .and_then(|x| x.as_bool())
                 .unwrap_or(false),
             #[cfg(feature = "_cargo_insta_internal")]
-            review_include_ignored: resolve(&cfg, &["test", "include_ignored"])
+            review_include_ignored: resolve(&cfg, &["review", "include_ignored"])
                 .and_then(|x| x.as_bool())
                 .unwrap_or(false),
         })