Fixed issue with closing files in fPutObject() function

[meefik]

When using the fPutObject() function, in case of an error, the file opened for reading is not closed.

How to reproduce

1. Make a test file /tmp/test

touch /tmp/test

2. Create test.js

const Minio = require('minio')

const client = new Minio.Client({
  useSSL: false,
  endPoint: '127.0.0.1',
  port: 9000,
  accessKey: 'minioadmin',
  secretKey: 'minioadmin'
})

setInterval(() => {
  client.fPutObject('test', 'test', '/tmp/test')
    .then(() => console.log('ok'))
    .catch(err => console.log(err))
}, 1000)

3. Run test.js

node test.js

4. Check open files for the process

lsof -p $(pgrep node)

...
node    52282 user   94r      REG                9,0        0 47450575 /tmp/test
node    52282 user   95r      REG                9,0        0 47450575 /tmp/test
node    52282 user   96r      REG                9,0        0 47450575 /tmp/test

When files are correctly closed they should not be in this list.

[prakashsvmx]

@meefik Thank you for the contribution.

I have not been able to replicate this . could you share versions of node, os etc to troubleshoot further and verify it?

[meefik]

@prakashsvmx

• Linux - Debian 11 (amd64)
• node - 18.15.0
• minio-js - 7.0.33

MinIO server is not required, the problem is reproduced when the connection to the server fails.