Fix multipart upload with encryption context #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
fix-multipart-with-context
branch
from
f63a038
to
4ecb4d7
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
fix-multipart-with-context
branch
from
4ecb4d7
to
3d8a6b5
Compare
alanprot
changed the title
harshavardhana
requested changes
Jun 13, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
fix-multipart-with-context
branch
from
7baa9c3
to
fc7d838
Compare
harshavardhana
approved these changes
Jun 14, 2023
3 tasks
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1777
The context header is also not allowed when completing the multipart upload on S3 and should be removed.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html
I also created a unit test to check all those behaviors.