Update minio.Core API #1764
Merged
Update minio.Core API #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Jan 27, 2023
donatello
force-pushed
the
multipart
branch
2 times, most recently
from
90e7195
to
4015a7b
Compare
donatello
force-pushed
the
multipart
branch
2 times, most recently
from
dcee182
to
d61d3b3
Compare
|
This is a breaking change. If we decide to break can't we add params as a struct? |
donatello
force-pushed
the
multipart
branch
2 times, most recently
from
d89fbf7
to
a4305c7
Compare
Added function input as a struct. |
harshavardhana
approved these changes
Feb 6, 2023
harshavardhana
requested changes
Feb 6, 2023
harshavardhana
approved these changes
Feb 6, 2023
klauspost
approved these changes
Feb 7, 2023
|
Please rebase this with master @donatello |
These breaking changes are added: - Add custom headers and trailers parameters for PutObjectPart and update input parameters to a struct - Expose upload info in CompleteMultipartUpload
|
Done @harshavardhana |
harshavardhana
approved these changes
Feb 24, 2023
|
this change has broken the mint build, see issue #355 there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These breaking changes are added:
Add custom headers parameter for PutObjectPart
Expose upload info in CompleteMultipartUpload