Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup #769

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Some cleanup #769

merged 4 commits into from
Apr 20, 2023

Conversation

martijn00
Copy link
Contributor

@ebozduman
Copy link
Collaborator

@martijn00
I took the liberty to add a clean up code change in this PR, the unnecessary targets in our tests.
These unnecessary targets were required to be installed in the container where the release script runs.

@martijn00
Copy link
Contributor Author

@ebozduman fine with me! Any other areas of the code you feel cleanup is required?

@ebozduman
Copy link
Collaborator

I think we have more than enough to make a release.
I am currently testing the release process.
As soon as I am done, we'll make a new release.

ebozduman
ebozduman approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit b505805 into minio:master Apr 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martijn00 @ebozduman