Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update properties parameter type in alter_collection_properties … #2590

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

elijahxb
Copy link

fix typehint error.

@sre-ci-robot
Copy link

Welcome @elijahxb! It looks like this is your first PR to milvus-io/pymilvus 🎉

@elijahxb
Copy link
Author

/assign @czs007

@elijahxb
Copy link
Author

#2566 fix type hint error

@elijahxb elijahxb mentioned this pull request Jan 22, 2025
1 task
@XuanYang-cn
Copy link
Contributor

The changes LGTM, I'll merge this PR once you fix the DCO error.

Please sign-off this PR as the DCO robot suggests: https://github.com/milvus-io/pymilvus/pull/2590/checks?check_run_id=35983237075

@mergify mergify bot added the ci-passed label Jan 24, 2025
@czs007
Copy link
Contributor

czs007 commented Jan 24, 2025

@elijahxb Thank you for your contribution.

The DCO can assist GitHub in better recognizing your identity and accurately tracking the number and details of your commits. The "signed off" in the DCO requires the addition of your primary GitHub email address.

Here is my public email in github settings:
image

To resolve the DCO issue, please refer to the following instructions:
image

Additionally, you can directly open the corresponding page under the Details section of the DCO action to view the same instructions.
image

@elijahxb
Copy link
Author

@elijahxb Thank you for your contribution.

The DCO can assist GitHub in better recognizing your identity and accurately tracking the number and details of your commits. The "signed off" in the DCO requires the addition of your primary GitHub email address.

Here is my public email in github settings:

image

To resolve the DCO issue, please refer to the following instructions:

image

Additionally, you can directly open the corresponding page under the Details section of the DCO action to view the same instructions.

image

email settings fixed. Please verify again,thank you
/assign @czs007

…method

Signed-off-by: xiongbin <xiongbin@sensoro.com>
@elijahxb
Copy link
Author

elijahxb commented Feb 6, 2025

/assign @czs007 dco fixed.

@elijahxb
Copy link
Author

elijahxb commented Feb 6, 2025

The changes LGTM, I'll merge this PR once you fix the DCO error.

Please sign-off this PR as the DCO robot suggests: https://github.com/milvus-io/pymilvus/pull/2590/checks?check_run_id=35983237075

/assign @XuanYang-cn DCO error fixed.

@XuanYang-cn XuanYang-cn added this to the 2.5.5 milestone Feb 18, 2025
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elijahxb, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f2eac55 into milvus-io:2.5 Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants