Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Restful server return milvus error code and http code in same field, may cause confusion. #33099

Open
1 task done
aoiasd opened this issue May 16, 2024 · 0 comments
Open
1 task done

[Enhancement]: Restful server return milvus error code and http code in same field, may cause confusion. #33099

aoiasd opened this issue May 16, 2024 · 0 comments
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@aoiasd
Copy link
Contributor

aoiasd commented May 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Return milvus Ok codes when success.

Why is this needed?

Milvus restful api return data["code"] with milvus code when failed but return http.OK when it success, may cause confusion.

Anything else?

No response
@aoiasd aoiasd added the kind/enhancement Issues or changes related to enhancement label May 16, 2024
@aoiasd aoiasd mentioned this issue May 16, 2024
Closed
This was referenced May 24, 2024
Merged
Merged
sre-ci-robot pushed a commit that referenced this issue May 26, 2024
@PowderLi
fix: [cherry-pick] [restful v2] search result be cut while nq > 1 (#3…
aaecc92 
…3363)

issue: #33099 #32837 #32419
master pr: #33339

1. len(search result) may be nq * topk, we need return all rather than
topk
2. the  in restful response payload keep the same with milvus error code

Signed-off-by: PowderLi <min.li@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue May 27, 2024
@PowderLi
fix: [restful v2] search result be cut while nq > 1 (#33339)
ee73e62 
issue: #33099 #32837 #32419

1. len(search result) may be nq * topk, we need return all rather than
topk
2. the  in restful response payload keep the same with milvus error code

Signed-off-by: PowderLi <min.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoiasd