Postgres Native Enum with * schema

[PrestonGiorgianni]

Describe the bug

While trying to use the schema: * option to allow multiple postgres schemas to be created with the same classes, I have noticed that the update command does not generate the proper Enum types. There are all generated as *.${nativeEnumName} instead of ${options.schema}.${nativeEnumName}.

I have tracked the issue down to this code block, where meta.schema is * and thus that is what is used in generating the sql. I am unfamiliar with the project and how best this could be fixed.

output

create type "*"."axis_move_axis_type_enum" as enum ();

desired output

create type "test"."axis_move_axis_type_enum" as enum ();

mikro-orm/packages/knex/src/schema/DatabaseSchema.ts

Lines 88 to 101 in 5180b6a

	if (prop.nativeEnumName) {
	let key = prop.nativeEnumName;
	const s = meta.schema ?? schema.name;
	if (s && s !== platform.getDefaultSchemaName()) {
	key = s + '.' + key;
	}
	nativeEnums[key] = {
	name: prop.nativeEnumName,
	schema: meta.schema ?? schema.name,
	items: prop.items?.map(val => '' + val) ?? [],
	};
	}

additional context

the create sql function also has issues with the * schema. It generates this sql, where the enum has the schema in it twice, but the create table references the enum differently.

create type "test"."test.axis_move_axis_type_enum" as enum ();
create table "test"."axis_move" ("id" serial primary key, "axis_type" axis_move_axis_type_enum not null);

Reproduction

//Type def
import { Entity, Enum, PrimaryKey, Property } from "@mikro-orm/core";

export enum AxisType {
...
}

@Entity({tableName: "axis_move", schema: "*"})
export class AxisMove {
  @Enum({
    type: 'AxisType',
    name: "axis_type",
    nativeEnumName: "axis_move_axis_type_enum",
  })
  axisType: "linear" | "rotary";
...
}

// schema generator
import { MikroORM } from '@mikro-orm/core';
import config from './config.js';

const orm = await MikroORM.init(config);
const schemaGenerator = orm.getSchemaGenerator();

console.log(await schemaGenerator.getUpdateSchemaSQL({
  schema: 'test',
}));
orm.close();

What driver are you using?

@mikro-orm/postgresql

MikroORM version

6.2.1

Node.js version

v20.11.1

Operating system

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Slack.
• The provided reproduction is a minimal reproducible example of the bug.

[B4nan]

I was looking into this yesterday, and the challenging part is diffing combined with support for enums in a specific schema (for entity in wildcard schema). Will need to give it a bit more time, worst case I'll implement at least the support for wildcard enums in general, as that should be rather easy (and I got that mostly already implemented locally).

[B4nan]

not perfect, but it should cover your use case