Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): escape array literal values containing backslash #4797

Merged
merged 4 commits into from
Oct 7, 2023
Merged

fix(postgres): escape array literal values containing backslash #4797

merged 4 commits into from
Oct 7, 2023
+56 −1

Conversation

Strengthless
Copy link
Contributor

Fixes #4796.

@Strengthless
fix: driver excepton when inserting array with single backslash

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
94f5fde
@Strengthless
test(gh4796): insert array of single backslash without errors

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
532f4c6
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/postgresql/src/PostgreSqlPlatform.ts 99.21% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@Strengthless
test(gh4796): make sure the stored db value is not malformed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3d129fc
B4nan
B4nan reviewed Oct 7, 2023
View reviewed changes
@B4nan B4nan changed the title fix: postgresql driver exception when inserting array with single backslash fix(postgres): escape array literal values containing backslash Oct 7, 2023
@Strengthless
Copy link
Contributor Author

Strengthless commented Oct 7, 2023 •
edited
Loading

Not sure whether the new title is more descriptive or misleading...

The issue seems to be some weird bug specific to single backslash, as both orm.em.create(User, { options: ['\\\\'] }) and orm.em.create(User, { options: ['\\test'] }) worked perfectly when I was trying to debug my code, if I remember correctly. Might want to double check though.

But I guess it doesn't really matter ¯\_(ツ)_/¯

@B4nan B4nan merged commit 20179ec into mikro-orm:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed array literal when handling single backslash in an array
2 participants
@Strengthless @B4nan