Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about asynctest and Python 3.8+ compatibility #161

Closed
Hellseher opened this issue Oct 14, 2022 · 3 comments · Fixed by #226
Closed

Question about asynctest and Python 3.8+ compatibility #161

Hellseher opened this issue Oct 14, 2022 · 3 comments · Fixed by #226
Labels
chore General maintenance items

Comments

@Hellseher
Copy link

Hi,

While packing your project for Guix I've faced with issue of abandoned Martiusweb/asynctest project wich you use in

pytest-socket/tests/test_async.py

Line 10 in 57c905e

import asynctest
but the project itself lost support for Python 3.8+.

May you provide any details on further requirements for Martiusweb/asynctest in your test suit?

Thanks.
@miketheman
Copy link
Owner

Thanks for the report!

Usage of asynctest is only in a single usage you referenced, to execute a test suite that uses the asynctest library, reported back in #6

If the library is no longer active, I would be happy to review a pull request to remove it, but ot does still appear to work: https://github.com/miketheman/pytest-socket/actions/runs/3101558257/jobs/5343958310#step:5:51

@miketheman miketheman added the more-info-needed Further information is requested label Oct 31, 2022
@miketheman
Copy link
Owner

asynctest completely fails in Python 3.11 - see #175

Going to need to resolve this somehow.

@miketheman miketheman added chore General maintenance items and removed more-info-needed Further information is requested labels Dec 19, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Marked stale due to inactivity label Mar 20, 2023
@miketheman miketheman removed the stale Marked stale due to inactivity label Mar 20, 2023
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 11, 2023
@dvzrv
upgpkg: python-pytest-socket 0.6.0-3: Rebuild against Python 3.11.
62c7ca2 
Disable broken test: miketheman/pytest-socket#161
Use bash arrays with one entry per line for better handling.
Remove unnecessary quotes and curly braces.

git-svn-id: file:///srv/repos/svn-community/svn@1444751 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 11, 2023
@dvzrv
upgpkg: python-pytest-socket 0.6.0-3: Rebuild against Python 3.11.
f4c303b 
Disable broken test: miketheman/pytest-socket#161
Use bash arrays with one entry per line for better handling.
Remove unnecessary quotes and curly braces.

git-svn-id: file:///srv/repos/svn-community/svn@1444751 9fca08f4-af9d-4005-b8df-a31f2cc04f65
miketheman added a commit that referenced this issue Jun 18, 2023
@miketheman
test: remove deprecated asynctest
ad81bcf 
The author has mentioned that they no longer work on the library.
Martiusweb/asynctest#158 (comment)

Since we have other tests in place now that exercise asyncio-style
tests, we can remove this test and dependency.

Resolves #161

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman mentioned this issue Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore General maintenance items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove deprecated asynctest miketheman/pytest-socket
2 participants
@miketheman @Hellseher