Add number in the list of properties supported for rules
#1091
Conversation
mikepenz
changed the title
number in the list of properties supported for rulesnumber in the list of properties supported for rules
| }) | ||
|
|
||
|
|
||
| it('Use Rules to get current open PR and merged categorised.', async () => { |
There was a problem hiding this comment.
@mikepenz thanks for your support!
I have the feeling I am doing something wrong.... to check if the rules works correctly, i added a test. it seems that rules are combined with and logic and due to that, no output is generated in this case.
There was a problem hiding this comment.
ps: sorry that my linter messed up :(
There was a problem hiding this comment.
@mikepenz to solve the issue, I introduced an additional configuration that allows to define whether rules are exclusive or not: category.exclusive_rules. When this value is not set, to guarantee backward compatibility, it is set to the same value as category.exhaustive.
I locally run tests, and all passes, including the one i defined.
|
Thank you very much for the contribution. Decided to rename |
Thank you for accepting my contribute! |
fixes #1079