dev -> main #969
Merged
dev -> main #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, tapping on a library for which no license is known would pop up a dialog with the license of whatever library was previously bound to the view holder.
Set onclick listener of SimpleLibraryItem to null if no license is known
Previously, the following crash would occur if a ``libraryComparator``
is set:
```
java.lang.UnsupportedOperationException: Operation is not supported for read-only collection
at kotlinx.collections.immutable.implementations.immutableList.AbstractListIterator.set(Unknown Source:4)
at java.util.List.sort(List.java:533)
at java.util.Collections.sort(Collections.java:210)
at com.mikepenz.aboutlibraries.viewmodel.LibsViewModel$listItems$1$1.invokeSuspend(LibsViewModel.kt:95)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
```
- gradle build 8.3.1 - dokka 1.9.20 - kotlin core 1.9.23 - compose 1.6.4 - compose ui 1.6.4 - compose compiler 1.5.11 - compose multiplatform 1.6.1
…240323 Update major dependencies | Compose 1.6.4 | Compose-MP 1.6.1
… into alexbakker-fix-sort-crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.