New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect input format based on file name extension #1582
Conversation
Looks really good - could you add some acceptance tests (see acceptance_tests folder) to test that the detection works for the various file types? |
44f6fed
to
b412fd2
Compare
@mikefarah Thank you! I added a test, actually just copied but removing the explicit |
45fbf37
to
0ad46f0
Compare
@mikefarah, any idea why
|
Looks like the |
I don't think this belongs in a v4.x release. |
@hubchub, no, detecting input format based on the filename is not really breaking, as it works only when the input format is not specified. Meanwhile the explicitly set input format is always respected, just like how it behaved in the past. If you meant the change related to the default output format, that's a separate topic. |
When the inputFormat is not specified, instead of just assume the input format to be "yaml", we can also look at the input filename, more specifically the file extension, to deduce the input format.
This Fixes #1440.