Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Compact Answers OK flag in EDNS #1639

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

chreo
Copy link
Contributor

@chreo chreo commented Mar 10, 2025

Compact Answers OK flag is a signal that a queryer or server understand and can validate Compact Denial of Existance answers allowing RCODE NXDOMAIN restoration with single NSEC/NSEC3.
Flag is allocated by IANA: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-13 Compact Denial of Existance: https://www.iana.org/go/draft-ietf-dnsop-compact-denial-of-existence-07

Thanks for you pull request, do note the following:

  • If your PR introduces backward incompatible changes it will very likely not be merged.

  • We support the last two major Go versions, if your PR uses features from a too new Go version, it
    will not be merged.

@chreo chreo requested review from miekg and tmthrgd as code owners March 10, 2025 17:33
@miekg
Copy link
Owner

miekg commented Mar 10, 2025

oh wow a whole new bit assigned. wow :)

@miekg
Copy link
Owner

miekg commented Mar 10, 2025

lgtm, you can update the README and add this draft to the list of RFC. Will change the reference once this is an RFC.

@miekg
Copy link
Owner

miekg commented Mar 11, 2025

Pieter Lexis made this comment on mastodon though:

@miek I'm not on my PC now (no GH access(. But I think the Z() and SetZ() functions needs their bitshifts altered as well in this PR?

@chreo chreo force-pushed the dnssec/compact_answers_ok branch from 1a7ed19 to 544a98e Compare March 12, 2025 10:43
@chreo
Copy link
Contributor Author

chreo commented Mar 12, 2025

Pieter Lexis made this comment on mastodon though:

@miek I'm not on my PC now (no GH access(. But I think the Z() and SetZ() functions needs their bitshifts altered as well in this PR?

Thanks! and yeah, SetZ for EDNS clobbers CO flag unless modified. Fixed in latest version

Compact Answers OK flag is a signal that a queryer or server understand
and can validate Compact Denial of Existance answers allowing RCODE
NXDOMAIN restoration with single NSEC/NSEC3.
Flag is allocated by IANA: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-13
Compact Denial of Existance: https://www.iana.org/go/draft-ietf-dnsop-compact-denial-of-existence-07
@chreo chreo force-pushed the dnssec/compact_answers_ok branch from 544a98e to e8f532c Compare March 12, 2025 10:50
@chreo
Copy link
Contributor Author

chreo commented Mar 12, 2025

lgtm, you can update the README and add this draft to the list of RFC. Will change the reference once this is an RFC.

Added the draft as:

  • Draft - Compact Denial of Existence in DNSSEC

@miekg miekg merged commit 8d0c412 into miekg:master Mar 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants