Backport of i18n lookup table changes to 4.x, fixes misc url_for issues #2604
Conversation
Lookup table implementation backported from master. This solves a bug where fully localized templates links can't be generated by url_for and link_to helper methods.
Helper methods url_for and link_to could not get the correct paths when mount config option was set to "false". Fixed it by adding an unlocalized path to the lookup table.
New test to make sure "mount_at_root: false" works as intended, includes previously failing case of fully localized templates (e.g.: hello.en.html.erb).
guillerodriguez
changed the title
|
Thanks for that @guillerodriguez! The current situation of MM ( Last month I've discussed with @tdreyno and we came up with this plan: #2569 (comment). |
If this helps making MM move forward then it is welcome :-) |
|
@guillerodriguez I can merge if you're able to resolve those broken tests |
@tdreyno Not sure these failures are actually related to the changes in the PR -- all jobs failed early, in the ruby/setup-ruby@v1 action. This is before actually attempting to run any tests... |
|
Can you re-run the tests, might have been a GH issue. I don't have permissions to restart your actions |
I don't think I can do that either (or can't find how), perhaps because it's been more than 30 days since the original run. I will try to update the branch to see if that triggers a re-run. |
Done. Now it says the workflow is "awaiting approval from a maintainer": https://github.com/middleman/middleman/actions/runs/4106777042 |
Success :-) |
|
Thank you 🙏🏻 @guillerodriguez |
Backport of #2263 (reimplementation of i18n lookup table) to 4.x branch, including a fix for issue #2594, which was introduced by the referenced PR.
Fixes #2280, fixes #2592.