Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant target checks #2973

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Remove redundant target checks #2973

merged 1 commit into from
Apr 5, 2024

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Apr 4, 2024

This is a test to see whether these checks are really necessary given that windows-targets should already eliminate invalid target crate download and compilation.

And the build seems to confirm this. So unless there are counter arguments, this seems like the way to go.

Copy link
Collaborator

@dpaoliello dpaoliello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more that I think about this, the more that I like it - initially I was hesitant since anybody who may have accidently depended on the wrong crate will now get a linker error, whereas before it would silently work. That said, someone may be depending on one of these and thinking it is doing something and not realizing that it is a no-op.

Copy link
Collaborator

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very much in favour of build scripts being as minimal as possible.

@kennykerr kennykerr merged commit 879c0cf into master Apr 5, 2024
69 checks passed
@kennykerr kennykerr deleted the redundant-target-checks branch April 5, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants