Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline hints #113276

Closed
Kingwl opened this issue Dec 22, 2020 · 8 comments · Fixed by #113285 or #113412
Closed

Support inline hints #113276

Kingwl opened this issue Dec 22, 2020 · 8 comments · Fixed by #113285 or #113412
Assignees
@jrieken
Labels
api-proposal editor-contrib Editor collection of extras feature-request Request for new features or functionality verified Verification succeeded
Milestone
January 2021

Comments

@Kingwl
Copy link
Contributor

Kingwl commented Dec 22, 2020 •
edited

We have #16221.
But it's has been locked. I'd like to try work on this and ts side.
And as the result. I have reopen this issue for track.
Thanks!
@Kingwl Kingwl mentioned this issue Dec 22, 2020
Closed
5 tasks
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 22, 2020

Related: microsoft/TypeScript#42073

@Kingwl Kingwl mentioned this issue Dec 22, 2020
Merged
@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 22, 2020

I‘d like to add a new language feature provider: signautre arguments label provider (whatever)

It's basically works as codelens or semantictokens (I'm not sure).

And i have draft an PR.

@Kingwl Kingwl changed the title Show inline parameter hints Show inline arguments label Dec 22, 2020
@Kingwl Kingwl changed the title Show inline arguments label Support inline hits Dec 24, 2020
@Kingwl Kingwl mentioned this issue Dec 25, 2020
Merged
@Kingwl Kingwl changed the title Support inline hits Support inline hints Dec 28, 2020
@jrieken
Copy link
Member

jrieken commented Jan 6, 2021

I have unlocked the original issue and closing this as dupe. However, in the name of peace and productivity: let's continue discussions on the PR so that we can stay focused.

@jrieken jrieken closed this as completed Jan 6, 2021
@jrieken jrieken added this to the January 2021 milestone Jan 19, 2021
@jrieken jrieken added editor-contrib Editor collection of extras feature-request Request for new features or functionality api-proposal labels Jan 19, 2021
@kieferrm kieferrm mentioned this issue Jan 19, 2021
Closed
73 tasks
@jrieken jrieken added the verification-needed Verification of issue is requested label Jan 25, 2021
@jrieken
Copy link
Member

jrieken commented Jan 25, 2021

verify that latest vscode.proposed.d.ts has new API that allows to register an InlineHintProvider. No further/deep test is required at this point

fyi - use the vscode-dts-utility to use the latest version of vscode.d.ts and/or vscode.proposed.d.ts

@aeschli
Copy link
Contributor

aeschli commented Jan 26, 2021

Verified by creating a extension with yo code --insiders

@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jan 26, 2021
@weinand weinand mentioned this issue Feb 2, 2021
Closed
@kieferrm kieferrm mentioned this issue Feb 8, 2021
Closed
70 tasks
@Kingwl
Copy link
Contributor Author

Kingwl commented Feb 9, 2021

Hey folks.
I see this Issues has been includes in the iteration plan for Feb.
Anything I could help? Very looking forward to land & improve this one.

@jrieken
Copy link
Member

jrieken commented Feb 9, 2021 •
edited

We are currently in talks with other potential consumers about API tweaks and we have collected feedback on how the UI can be improved. We are likely tweaking the API a little during this milestone, but this month we will likely not improve the rendering much

@Jack-Works
Copy link
Contributor

related to microsoft/language-server-protocol#956?

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api-proposal editor-contrib Editor collection of extras feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
January 2021
Development

Successfully merging a pull request may close this issue.

Inline Hints controller and API proposal Kingwl/vscode
Add ts inline hints Kingwl/vscode
5 participants
@jrieken @Jack-Works @aeschli @Kingwl @mjbvz