Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search provider for scheme vscode-test-web #114

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Add search provider for scheme vscode-test-web #114

merged 6 commits into from
Jan 26, 2024

Conversation

wkillerud
Copy link
Contributor

@wkillerud wkillerud commented Dec 14, 2023

Hello 馃憢

I've investigated the file search provider proposal in order to solve #39

Unfortunately, actually filtering seems to be blocked by microsoft/vscode#200892 (edit: only on the provider side, filtering happens on the client)

I'm testing with https://github.com/wkillerud/vscode-scss/tree/repro/no-search-provider and npm linking in ./web. The language server now gets a list of files in the workspace, where before it would get nothing.

When using the URIs for requests, for instance for reading contents
of the file, /static/mount had to be removed
@wkillerud
Copy link
Contributor Author

wkillerud commented Dec 17, 2023

This seems to be working pretty well, testing with https://github.com/wkillerud/vscode-scss/tree/repro/no-search-provider

I noted over on microsoft/vscode#200892 (comment)

It looks like the filtering is done correctly on the client-side / in VS Code, so the provider can return all files as "matches" and still kind of work.

I'll mark this as ready for review.

@wkillerud wkillerud marked this pull request as ready for review December 17, 2023 13:31
@aeschli
Copy link
Contributor

aeschli commented Jan 26, 2024

Thanks @wkillerud !

@VSCodeTriageBot VSCodeTriageBot added this to the December / January 2024 milestone Jan 26, 2024
@aeschli aeschli enabled auto-merge (squash) January 26, 2024 16:33
@aeschli aeschli merged commit cca88dc into microsoft:main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants