Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a NuGet package that offers the library without the analyzers #1435

Merged
merged 3 commits into from
Mar 17, 2025

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Mar 17, 2025

No description provided.

AArnott added 3 commits March 11, 2025 10:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This new package has the library, but no analyzers dependency.
The analyzers dependency is retained by the original `Microsoft.VisualStudio.Threading` package, along with a new dependency on the `Microsoft.VisualStudio.Threading.Only` package.

This allows consumers like StreamJsonRpc to express a dependency on `Microsoft.VisualStudio.Threading.Only` instead of `Microsoft.VisualStudio.Threading` in order to prevent its downstream users from having threading analyzers applied automatically, which they may not want.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@AArnott AArnott added this to the v17.13 milestone Mar 17, 2025
@AArnott AArnott enabled auto-merge March 17, 2025 15:24
@AArnott AArnott merged commit 8e16631 into v17.13 Mar 17, 2025
7 checks passed
@AArnott AArnott deleted the ThreadingOnlyPackage branch March 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants