Revert change for timeout test execution #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through the process of simplification and unification of behaviors for the different target frameworks, we dropped usage of a thread to use only Task.Run. This has the unexpected side effect of causing .NET framework tests to no longer be run in STA thread. We are reverting the change for now and are tracking the implementation of a better solution with microsoft#1674
Evangelink
added a commit
to Evangelink/testfx
that referenced
this pull request
May 22, 2023
Evangelink
added a commit
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the process of simplification and unification of behaviors for the different target frameworks, we dropped usage of a thread to use only Task.Run. This has the unexpected side effect of causing .NET framework tests to no longer be run in STA thread.
We are reverting the change for now and are tracking the implementation of a better solution with #1674
Fixes #1616