Remove ValidationException #749
Merged
+71
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
stephentoub
force-pushed
the
validationexception
branch
from
4be2266 to
83ba112
Compare
The conditions ValidationException was used for validating are better suited to existing .NET exception types that .NET developers expect in those situations. - NotNullOrWhiteSpace is represented with ArgumentException. - Directory not found is represented with DirectoryNotFoundException - Invalid state of an object (e.g. a field not being initialized) is represented with InvalidOperationException Argument validation exceptions are also usage exceptions typically not intended to be caught. The same would go for the ValidationExceptions that were serving the same purpose, so having a separate type identity for those exceptions isn't desirable.
shawncal
force-pushed
the
validationexception
branch
from
83ba112 to
a9666de
Compare
adrianwyatt
previously approved these changes
May 1, 2023
adrianwyatt
added
the
PR: ready for review
shawncal
reviewed
May 1, 2023
shawncal
reviewed
May 1, 2023
shawncal
approved these changes
May 1, 2023
awharrison-28
pushed a commit
to awharrison-28/semantic-kernel
that referenced
this pull request
May 1, 2023
Remove custom ValidationException in favor of using built-in .NET exception types typically used for the same purposes. ### Description The conditions ValidationException was used for validating are better suited to existing .NET exception types that .NET developers expect in those situations. - NotNullOrWhiteSpace is represented with ArgumentException. - Directory not found is represented with DirectoryNotFoundException - Invalid state of an object (e.g. a field not being initialized) is represented with InvalidOperationException Argument validation exceptions are also usage exceptions typically not intended to be caught. The same would go for the ValidationExceptions that were serving the same purpose, so having a separate type identity for those exceptions isn't desirable.
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
Remove custom ValidationException in favor of using built-in .NET exception types typically used for the same purposes. ### Description The conditions ValidationException was used for validating are better suited to existing .NET exception types that .NET developers expect in those situations. - NotNullOrWhiteSpace is represented with ArgumentException. - Directory not found is represented with DirectoryNotFoundException - Invalid state of an object (e.g. a field not being initialized) is represented with InvalidOperationException Argument validation exceptions are also usage exceptions typically not intended to be caught. The same would go for the ValidationExceptions that were serving the same purpose, so having a separate type identity for those exceptions isn't desirable.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
Remove custom ValidationException in favor of using built-in .NET exception types typically used for the same purposes. ### Description The conditions ValidationException was used for validating are better suited to existing .NET exception types that .NET developers expect in those situations. - NotNullOrWhiteSpace is represented with ArgumentException. - Directory not found is represented with DirectoryNotFoundException - Invalid state of an object (e.g. a field not being initialized) is represented with InvalidOperationException Argument validation exceptions are also usage exceptions typically not intended to be caught. The same would go for the ValidationExceptions that were serving the same purpose, so having a separate type identity for those exceptions isn't desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove custom ValidationException in favor of using built-in .NET exception types typically used for the same purposes.
Description
The conditions ValidationException was used for validating are better suited to existing .NET exception types that .NET developers expect in those situations.
Argument validation exceptions are also usage exceptions typically not intended to be caught. The same would go for the ValidationExceptions that were serving the same purpose, so having a separate type identity for those exceptions isn't desirable.
Contribution Checklist
dotnet formatcc: @shawncal, @dluc