-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net - Add support for agent tools: code-interpreter and retrieval tool #4546
Merged
+810
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliscode
reviewed
Jan 10, 2024
alliscode
approved these changes
Jan 10, 2024
…antic-kernel into update_agent_tools
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
glahaye
reviewed
Jan 10, 2024
Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
…antic-kernel into update_agent_tools
glahaye
approved these changes
Jan 10, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…ol (microsoft#4546) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Enable deeper alignment with Open AI features: code-interpreter and retrieval ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - Add support to enable code-interpreter and retrieval - Add support to associated uploaded files with agent - Files must be uploaded outside of the Agent API and then referenced by identifier - Added support for message citations Known issue where Open AI API text includes citation reference and no corresponding annocations: ``` { "id": "msg_jCIdC8gdO5yPylbP9JMGCNO0", "object": "thread.message", "created_at": 1704872920, "thread_id": "thread_BQLiJQFVFxfNH2blMROZYDQ2", "role": "assistant", "content": [ { "type": "text", "text": { "value": "Sam Marks went on a trip from Seattle to Raleigh/Durham. According to the itinerary, Sam departed from Seattle-Tacoma International Airport (SEA) on Monday, September 11, 2023, at 10:05 AM on Alaska Airlines Flight AS 572 and arrived in Raleigh (RDU) at 06:15 PM【6†source】. Sam stayed for two nights【4†source】 and returned on Wednesday, September 13, 2023, departing from Raleigh (RDU) at 07:15 PM on Alaska Airlines Flight AS 491 and arrived back in Seattle (SEA) at 09:59 PM【7†source】.", "annotations": [] } } ], "file_ids": [], "assistant_id": "asst_2zdSRjQJCyAKdXvhqw9dNrie", "run_id": "run_Rn5nJPncHY41nAr5VgOvPeyC", "metadata": {} } ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
experimental
Associated with an experimental feature
feature branch
PR targeting a feature branch
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Enable deeper alignment with Open AI features: code-interpreter and retrieval
Description
Known issue where Open AI API text includes citation reference and no corresponding annocations:
Contribution Checklist