.Net: [Fix] .Net: FunctionCallingStepwisePlannerTests.DoesNotThrowWhenPluginFunctionThrowsNonCriticalExceptionAsync is failing #4542
+39
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitri-ms
added
bug
shawncal
added
.NET
github-actions
bot
changed the title
SergeyMenshykh
approved these changes
Jan 9, 2024
alliscode
reviewed
Jan 9, 2024
dotnet/src/IntegrationTests/Planners/Stepwise/FunctionCallingStepwisePlannerTests.cs
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Jan 10, 2024
RogerBarreto
approved these changes
Jan 10, 2024
alliscode
approved these changes
Jan 10, 2024
markwallace-microsoft
approved these changes
Jan 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@gitri-ms Could you take a look as the problem still seems to be there, see: https://github.com/microsoft/semantic-kernel/actions/runs/7487880249/job/20381194144#step:6:319 |
Hmm... this looks like a different exception being thrown. Looking... |
glahaye
approved these changes
Jan 11, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…nPluginFunctionThrowsNonCriticalExceptionAsync is failing (microsoft#4542) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fix for failing integration test (resolves microsoft#4534) When using certain OpenAI models such as `gpt-3.5-turbo-1106`, the model would sometimes opt to call `GetEmailAddressAsync` when it wasn't actually needed. This was causing a critical exception to be thrown (which was by design for a different test case, but in this case was being called unexpectedly and causing the test to fail.) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> This change modifies the test scenarios to minimize the possibility of a critical exception being thrown by mistake. Now `WriteJokeAsync` throws the critical exception, so the other test cases (that involve writing/emailing poems) should not encounter it. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix for failing integration test (resolves #4534)
When using certain OpenAI models such as
gpt-3.5-turbo-1106, the model would sometimes opt to callGetEmailAddressAsyncwhen it wasn't actually needed. This was causing a critical exception to be thrown (which was by design for a different test case, but in this case was being called unexpectedly and causing the test to fail.)Description
This change modifies the test scenarios to minimize the possibility of a critical exception being thrown by mistake. Now
WriteJokeAsyncthrows the critical exception, so the other test cases (that involve writing/emailing poems) should not encounter it.Contribution Checklist