.Net: Invariant culture for OpenApiSchema conversion #4540
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… convert OpenAPI schema
SergeyMenshykh
requested review from
dmytrostruk,
RogerBarreto and
markwallace-microsoft
markwallace-microsoft
approved these changes
Jan 10, 2024
dmytrostruk
approved these changes
Jan 10, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
Closes : microsoft#4504 ### Motivation, Context and Description The issue occurred during the conversion from OpenApiSchema to KernelJsonSchema on environments with a culture that uses a comma as a decimal separator. To resolve this, the OpenApiSchemaExtensions.ToJsonSchema method has been updated to utilize the invariant culture for conversion instead of using current culture. <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #4504
Motivation, Context and Description
The issue occurred during the conversion from OpenApiSchema to KernelJsonSchema on environments with a culture that uses a comma as a decimal separator. To resolve this, the OpenApiSchemaExtensions.ToJsonSchema method has been updated to utilize the invariant culture for conversion instead of using current culture.