.Net: Bug fixes for Handlebars Prompt Template and Planner #4528
+159
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
SergeyMenshykh
approved these changes
Jan 9, 2024
RogerBarreto
approved these changes
Jan 11, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…#4528) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Squashing bugs related to variable access in the Handlebars Prompt Template Factory and enhancing the Handlebars Planner Create Plan prompt. Since we allow the planner to set variables after initial render call, these variables that are added during plan execution are not bound to the template and will resolve as an `UndefinedBindingResult` as the template evaluates. This PR adds a fix to handle that scenario. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Resolving variables: - If the argument is of type `UndefinedBindingResult`, it means that Handlebars attempted to retrieve the value for a binding but was unable to do so because the variable was not defined or not passed to the template context at the time of render. Thus, we try to get the value from the kernel arguments dictionary. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Teresa Hoang <tehoang@microsoft.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Squashing bugs related to variable access in the Handlebars Prompt Template Factory and enhancing the Handlebars Planner Create Plan prompt.
Since we allow the planner to set variables after initial render call, these variables that are added during plan execution are not bound to the template and will resolve as an
UndefinedBindingResultas the template evaluates. This PR adds a fix to handle that scenario.Description
Resolving variables:
UndefinedBindingResult, it means that Handlebars attempted to retrieve the value for a binding but was unable to do so because the variable was not defined or not passed to the template context at the time of render. Thus, we try to get the value from the kernel arguments dictionary.Contribution Checklist