Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net - Add support for instruction templating on Agents #4486

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Jan 5, 2024

Motivation and Context

  1. Agent instructions support template parameters
  2. Agent yaml identical / interchangeable with prompt config yaml

Description

Templating agents introduces much more dynamic capabilities, beyond the standard assistant API.

As part of this, the agent template and kernel-function template have converged.

Contribution Checklist

Sorry, something went wrong.

@crickman crickman added PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code enhancement agents labels Jan 5, 2024
@crickman crickman added this to the R4: Cycle 2 milestone Jan 5, 2024
@crickman crickman self-assigned this Jan 5, 2024
@crickman crickman requested a review from a team as a code owner January 5, 2024 01:41
@crickman crickman linked an issue Jan 5, 2024 that may be closed by this pull request
@crickman crickman changed the title .Net - Add support for instruction templating .Net - Add support for instruction templating on Agents Jan 5, 2024
crickman and others added 3 commits January 8, 2024 10:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@crickman crickman requested a review from glahaye January 8, 2024 18:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
crickman and others added 4 commits January 8, 2024 11:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@crickman crickman added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 0b3e542 Jan 8, 2024
@crickman crickman deleted the update_agent_templating branch January 8, 2024 21:38
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

1. Agent instructions support template parameters 
2. Agent yaml identical / interchangeable with prompt config yaml

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Templating agents introduces much more dynamic capabilities, beyond the
standard assistant API.

As part of this, the agent template and kernel-function template have
converged.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents enhancement .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

.Net Agent - Support prompt templating
3 participants