Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Bump Python Package version for release. Update notebook refs to use AIRequestSettings. #4478

Merged
merged 11 commits into from
Jan 5, 2024

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Jan 4, 2024

Motivation and Context

Bump Python Package version for release. Update notebook refs and request settings to use the new AIRequestSettings classes. Fix hugging face bug that requires generator input as text_inputs instead of prompt. Add a hugging face request settings unit test.

Description

Bump Python Package version for release. Update notebook refs to point to new package version.

Contribution Checklist

Sorry, something went wrong.

@moonbox3 moonbox3 requested a review from a team as a code owner January 4, 2024 15:12
@shawncal shawncal added the python Pull requests for the Python Semantic Kernel label Jan 4, 2024
@github-actions github-actions bot changed the title Bump Python Package version for release. Update notebook refs. Python: Bump Python Package version for release. Update notebook refs. Jan 4, 2024
@moonbox3 moonbox3 changed the title Python: Bump Python Package version for release. Update notebook refs. Python: Bump Python Package version for release. Update notebook refs to use AIRequestSettings. Jan 5, 2024
moonbox3 and others added 2 commits January 5, 2024 10:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change on the open_ai_request_settings and saw some error output stored in the notebook.

Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@moonbox3 moonbox3 added this pull request to the merge queue Jan 5, 2024
Merged via the queue into microsoft:main with commit 8618cd3 Jan 5, 2024
@moonbox3 moonbox3 deleted the evmattso/bump-version-for-release branch January 5, 2024 16:43
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
… to use AIRequestSettings. (microsoft#4478)

### Motivation and Context

Bump Python Package version for release. Update notebook refs and
request settings to use the new AIRequestSettings classes. Fix hugging
face bug that requires generator input as text_inputs instead of prompt.
Add a hugging face request settings unit test.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Bump Python Package version for release. Update notebook refs to point
to new package version.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <evan.mattson@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants