Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Fixed example10 printing plugin name and example in comment #4357

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

Krzysztof318
Copy link
Contributor

@Krzysztof318 Krzysztof318 commented Dec 18, 2023

.NET Fixed example10 printing plugin name and example in comment
PS: I removed first pull request accidentaly.

Motivation and Context

Output of example10 did not match the example in the commentary.

Description

Contribution Checklist

Added plugin name print to example10 and updated comment.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ment

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Krzysztof318 Krzysztof318 requested a review from a team as a code owner December 18, 2023 18:54
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Dec 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Dec 19, 2023
Merged via the queue into microsoft:main with commit b918618 Dec 19, 2023
@Krzysztof318 Krzysztof318 deleted the example10-fix branch January 11, 2024 21:05
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
…rosoft#4357)

.NET Fixed example10 printing plugin name and example in comment
PS: I removed first pull request accidentaly.

### Motivation and Context

Output of example10 did not match the example in the commentary.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

Added plugin name print to example10 and updated comment.

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants