.Net: Fix for #2820 Avoid unnecessary conversion of strings to Unicode encoding #4327
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent encoding Fixes microsoft#2820
stephentoub
reviewed
Dec 16, 2023
…, deemed safe as the JSON isn't used for security-sensitive operations. Added a warning in SearchAsync about potential risks.
SergeyMenshykh
approved these changes
Dec 19, 2023
RogerBarreto
approved these changes
Dec 19, 2023
|
@yuezhishun , please follow the license agreement change and we can merge it. |
@microsoft-github-policy-service agree |
dmytrostruk
approved these changes
Dec 20, 2023
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…to Unicode encoding (microsoft#4327) Fixes microsoft#2820 ### Motivation and Context This PR resolves an issue where search results containing UTF-8 characters were automatically converted to Unicode, adversely affecting readability and resulting in token wastage. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description [ This is the second submission addressing feedback from the initial review.](microsoft#4128) Changes have been made to explicitly use `UnsafeRelaxedJsonEscaping` for all serialization cases, as suggested by @stephentoub. Please review the modifications and provide further feedback. Thank you! <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com> Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2820
Motivation and Context
This PR resolves an issue where search results containing UTF-8 characters were automatically converted to Unicode, adversely affecting readability and resulting in token wastage.
Description
This is the second submission addressing feedback from the initial review. Changes have been made to explicitly use
UnsafeRelaxedJsonEscapingfor all serialization cases, as suggested by @stephentoub. Please review the modifications and provide further feedback. Thank you!Contribution Checklist