Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fix and add back FlowOrchestrator #4307

Merged

Conversation

yan-li
Copy link
Contributor

@yan-li yan-li commented Dec 15, 2023

Summary

This pull request includes a set of changes to the Orchestration.Flow project. The changes include adding a new project, Experimental.Orchestration.Flow, and updating the Example FlowOrchestrator to use it. Additionally, the email plugin has been refactored and a chat completion service has been added. Unused code has been removed, and integration and unit tests have been updated. The ReActEngine and FlowExecutor classes have been refactored to use KernelArguments and FunctionResult instead of ContextVariables and Dictionary<string, string>. The FlowOrchestrator and related extensions have been added to the Experimental.Orchestration.Flow namespace. Finally, plugin configurations have been updated to use input_variables and execution_settings instead of input.parameters and completion.

Changes

  • Added Experimental.Orchestration.Flow project
  • Added Experimental.Orchestration.Flow.IntegrationTests project
  • Added Experimental.Orchestration.Flow.UnitTests project
  • Updated Example FlowOrchestrator to use Experimental.Orchestration.Flow
  • Refactored email plugin to include a new EmailPluginV2 class and added chat completion service
  • Removed unused code related to an example of the plugin
  • Updated SendEmailPlugin class to use KernelArguments instead of ContextVariables
  • Updated IFlowExecutor interface to use FunctionResult instead of ContextVariables
  • Updated ChatHistorySerializerTest class to use the ChatCompletion namespace instead of the AI.ChatCompletion namespace
  • Added new KernelFunctions to FlowExecutor class for executing flows and steps
  • Refactored FlowExecutor to use KernelFunctionFactory
  • Refactored FlowExecutor to use KernelArguments and FunctionResult instead of ContextVariables and Dictionary<string, string>
  • Refactored ReActEngine to use KernelArguments instead of ContextVariablesExtensions
  • Added extension methods for FunctionResult and KernelArguments
  • Added FlowOrchestrator class to Experimental.Orchestration.Flow namespace
  • Modified PromptTemplateConfigExtensions.cs to set max tokens
  • Modified FlowOrchestrator.cs to use IKernelBuilder and IFlowStatusProvider interfaces
  • Updated CheckRepeatStep and CheckStartStep plugin configurations to use input_variables
  • Updated ReActEngine and gpt4 plugin configurations to use execution_settings
  • Updated ReActEngine GPT4 config.json file

Powered by Microsoft Semantic Kernel

Motivation and Context

Adopt latest interfaces and add back Experimental FlowOrchestrator.

Description

Contribution Checklist

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
svanharmelen Sander van Harmelen
@yan-li yan-li requested a review from a team as a code owner December 15, 2023 16:43
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Dec 15, 2023
@github-actions github-actions bot changed the title Fix and add back FlowOrchestrator .Net: Fix and add back FlowOrchestrator Dec 15, 2023
@yan-li
Copy link
Contributor Author

yan-li commented Dec 15, 2023

/sk generate-pr-description prefix

@github-actions github-actions bot changed the title .Net: Fix and add back FlowOrchestrator Update Orchestration.Flow project .Net: Fix and add back FlowOrchestrator Dec 15, 2023
Copy link

Generate PR Description: succeeded ✅
https://github.com/microsoft/semantic-kernel/actions/runs/7224723249

@yan-li yan-li changed the title Update Orchestration.Flow project .Net: Fix and add back FlowOrchestrator .Net: Fix and add back FlowOrchestrator Dec 15, 2023
@shawncal shawncal added the kernel Issues or pull requests impacting the core kernel label Dec 19, 2023
@yan-li yan-li requested a review from RogerBarreto December 19, 2023 14:16
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Dec 21, 2023
Merged via the queue into microsoft:main with commit 240a2cb Dec 21, 2023
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this pull request Oct 6, 2024
## Summary
This pull request includes a set of changes to the Orchestration.Flow
project. The changes include adding a new project,
Experimental.Orchestration.Flow, and updating the Example
FlowOrchestrator to use it. Additionally, the email plugin has been
refactored and a chat completion service has been added. Unused code has
been removed, and integration and unit tests have been updated. The
ReActEngine and FlowExecutor classes have been refactored to use
KernelArguments and FunctionResult instead of ContextVariables and
Dictionary<string, string>. The FlowOrchestrator and related extensions
have been added to the Experimental.Orchestration.Flow namespace.
Finally, plugin configurations have been updated to use input_variables
and execution_settings instead of input.parameters and completion.

## Changes
- Added Experimental.Orchestration.Flow project
- Added Experimental.Orchestration.Flow.IntegrationTests project
- Added Experimental.Orchestration.Flow.UnitTests project
- Updated Example FlowOrchestrator to use
Experimental.Orchestration.Flow
- Refactored email plugin to include a new EmailPluginV2 class and added
chat completion service
- Removed unused code related to an example of the plugin
- Updated SendEmailPlugin class to use KernelArguments instead of
ContextVariables
- Updated IFlowExecutor interface to use FunctionResult instead of
ContextVariables
- Updated ChatHistorySerializerTest class to use the ChatCompletion
namespace instead of the AI.ChatCompletion namespace
- Added new KernelFunctions to FlowExecutor class for executing flows
and steps
- Refactored FlowExecutor to use KernelFunctionFactory
- Refactored FlowExecutor to use KernelArguments and FunctionResult
instead of ContextVariables and Dictionary<string, string>
- Refactored ReActEngine to use KernelArguments instead of
ContextVariablesExtensions
- Added extension methods for FunctionResult and KernelArguments
- Added FlowOrchestrator class to Experimental.Orchestration.Flow
namespace
- Modified PromptTemplateConfigExtensions.cs to set max tokens
- Modified FlowOrchestrator.cs to use IKernelBuilder and
IFlowStatusProvider interfaces
- Updated CheckRepeatStep and CheckStartStep plugin configurations to
use input_variables
- Updated ReActEngine and gpt4 plugin configurations to use
execution_settings
- Updated ReActEngine GPT4 config.json file

---
*Powered by [Microsoft Semantic
Kernel](https://github.com/microsoft/semantic-kernel)*
### Motivation and Context
Adopt latest interfaces and add back Experimental FlowOrchestrator.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants