.Net: Add previous plan and error to retry the handdlebars planning. #3973
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeaugrand
force-pushed
the
dev/dotnet-fix-handlebars-retry
branch
from
467848a to
3f645ed
Compare
kbeaugrand
force-pushed
the
dev/dotnet-fix-handlebars-retry
branch
5 times, most recently
from
dff18cc to
c72de7a
Compare
kbeaugrand
force-pushed
the
dev/dotnet-fix-handlebars-retry
branch
2 times, most recently
from
5f8c706 to
e2332f7
Compare
kbeaugrand
force-pushed
the
dev/dotnet-fix-handlebars-retry
branch
from
e2332f7 to
e86ae40
Compare
markwallace-microsoft
added
the
v1.0.1
teresaqhoang
added
vnext
and removed
v1.0.1
dotnet/src/Planners/Planners.Handlebars/Handlebars/CreatePlanPrompt.handlebars
Outdated
Show resolved
Hide resolved
kbeaugrand
commented
Jan 8, 2024
dotnet/src/Planners/Planners.Handlebars/Handlebars/CreatePlanPrompt.handlebars
Outdated
Show resolved
Hide resolved
dotnet/src/Planners/Planners.Handlebars/Handlebars/CreatePlanPrompt.handlebars
Outdated
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Jan 11, 2024
SergeyMenshykh
approved these changes
Jan 11, 2024
|
@kbeaugrand sorry there are new merge conflicts to be resolved. If you can get these resolved today we should be able to include this change in our next release. Thanks! |
kbeaugrand
commented
Jan 11, 2024
dotnet/src/Planners/Planners.Handlebars/Handlebars/CreatePlanPrompt.handlebars
Show resolved
Hide resolved
dotnet/src/Planners/Planners.Handlebars/Handlebars/CreatePlanPrompt.handlebars
Outdated
Show resolved
Hide resolved
@markwallace-microsoft, I've just resolved those conflicts. |
SergeyMenshykh
approved these changes
Jan 11, 2024
markwallace-microsoft
approved these changes
Jan 11, 2024
markwallace-microsoft
approved these changes
Jan 11, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…icrosoft#3973) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fix microsoft#4144 -The handlebars planner don't use previous plan and previous error when creating a plan. This PR aims to provide a fix to this issue. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> I added a prompt to specify to the planner which plan was previously generated and the corresponding error. Those parameters are added only if the previous error is provided. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com> Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #4144 -The handlebars planner don't use previous plan and previous error when creating a plan. This PR aims to provide a fix to this issue.
Description
I added a prompt to specify to the planner which plan was previously generated and the corresponding error.
Those parameters are added only if the previous error is provided.
Contribution Checklist