Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async functions should accept and respect cancellation tokens #1677

Closed
chipalost opened this issue Jun 22, 2023 · 1 comment
Closed

Async functions should accept and respect cancellation tokens #1677

chipalost opened this issue Jun 22, 2023 · 1 comment
Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@chipalost
Copy link

Skills/plugins are async functions, but they can't take a cancellation token. Not only should those functions accept a cancellation token, it should be passed down and respected through chains of functions. Apparently there is a PR that fixes this. It's a large breaking change (in a good way) which needs careful planning about how/when it's introduced.
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Jun 22, 2023
@shawncal
Copy link
Member

Fixed with #1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chipalost @shawncal @evchaki