Add required flag to parameter description and improve plan creation #1223
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a "(required)" suffix to the description of any parameter that is marked as required in the OpenAPI schema. This makes it easier for users to see which parameters are mandatory when using the skills. Additionally, this commit improves the plan creation logic in the chat skill by passing the full context and user intent to the planner, and merging any context variables into the plan's state. This allows the planner to generate more relevant and accurate steps based on the user input and the current situation.
github-actions
bot
added
.NET
|
Assigning to @teresaqhoang to help test the changes and verify whether it helps with the issues they've been experiencing. |
lemillermicrosoft
requested review from
adrianwyatt,
SergeyMenshykh and
teresaqhoang
lemillermicrosoft
added
the
PR: in progress
teresaqhoang
previously approved these changes
May 25, 2023
|
LGTM! Here's a screenshot from my last verification |
lemillermicrosoft
added
PR: ready for review
SergeyMenshykh
previously approved these changes
May 25, 2023
adrianwyatt
previously approved these changes
May 25, 2023
adrianwyatt
dismissed stale reviews from teresaqhoang, SergeyMenshykh, and themself
via
342ef8e
|
I brought in a minor fix from a previous PR as well. |
adrianwyatt
approved these changes
May 25, 2023
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…icrosoft#1223) This commit adds a "(required)" suffix to the description of any parameter that is marked as required in the OpenAPI schema. This makes it easier for users to see which parameters are mandatory when using the skills. Additionally, this commit improves the plan creation logic in the chat skill by passing the full context and user intent to the planner, and merging any context variables into the plan's state. This allows the planner to generate more relevant and accurate steps based on the user input and the current situation.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…icrosoft#1223) This commit adds a "(required)" suffix to the description of any parameter that is marked as required in the OpenAPI schema. This makes it easier for users to see which parameters are mandatory when using the skills. Additionally, this commit improves the plan creation logic in the chat skill by passing the full context and user intent to the planner, and merging any context variables into the plan's state. This allows the planner to generate more relevant and accurate steps based on the user input and the current situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a "(required)" suffix to the description of any parameter that is marked as required in the OpenAPI schema. This makes it easier for users to see which parameters are mandatory when using the skills.
Additionally, this commit improves the plan creation logic in the chat skill by passing the full context and user intent to the planner, and merging any context variables into the plan's state. This allows the planner to generate more relevant and accurate steps based on the user input and the current situation.
Contribution Checklist
dotnet format