Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/rushstack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @rushstack/eslint-plugin-packlets_v0.9.2
Choose a base ref
...
head repository: microsoft/rushstack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @rushstack/eslint-plugin-packlets_v0.10.0
Choose a head ref
30 contributors

Commits on Jul 30, 2024

  1. [localization-plugin] Include webpack compilation in stats callback (#… 

    …4854)

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
    @dmichon-msft
    dmichon-msft and dmichon-msft authored Jul 30, 2024
    Copy the full SHA
    f099df4 View commit details

Commits on Jul 31, 2024

  1. Update changelogs [skip ci]

    @rushbot
    rushbot committed Jul 31, 2024
    Copy the full SHA
    fae0d99 View commit details

  2. Bump versions [skip ci]

    @rushbot
    rushbot committed Jul 31, 2024
    Copy the full SHA
    df93f1d View commit details

  3. fix(rush): don't panic when cache beforeExecute fails (#4852) 

    * fix(rush): don't panic when cache beforeExecute fails

* add changeset

---------

Co-authored-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
    @aramissennyeydd
    aramissennyeydd and aramissennyeydd authored Jul 31, 2024
    Copy the full SHA
    e619556 View commit details

  4. Update changelogs [skip ci]

    @rushbot
    rushbot committed Jul 31, 2024
    Copy the full SHA
    918ba28 View commit details

  5. Bump versions [skip ci]

    @rushbot
    rushbot committed Jul 31, 2024
    Copy the full SHA
    a9da32f View commit details

Commits on Aug 2, 2024

  1. [rush] Some new features about rush alerts (#4856) 

    * Add support for maxDailyDisplays in rush alerts to limit daily alert displays

* Add support for maxDailyDisplays in rush alerts to limit daily alert displays

* snooze alert

* feat: alert action

* fix: ci

* fix: ci

* loadFromConfiguration

* fix: ci

* feat: schema

* bug fix

* chore: remove mid priority

* adjust print format

* remove unnecessary action

* fix: ci

* fix: ci

* Fix a typo in the "rush init" template comment

* print new result after changes

* do not need inquirer

* add alertId field for rush-alerts schema

* fix some bugs

* fix ci

* Only display alerts when certain specific actions are triggered

* rush change

* improve code style

* Update some docs

* Prepare to publish a MINOR release

* Revert change to @internal method; move risky code behind experiment

* Update snapshots

---------

Co-authored-by: qun <L-Qun@users.noreply.github.com>
Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
    @L-Qun @octogonz
    3 people authored Aug 2, 2024
    Copy the full SHA
    4945500 View commit details

  2. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 2, 2024
    Copy the full SHA
    d13d423 View commit details

  3. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 2, 2024
    Copy the full SHA
    a89eaf2 View commit details

  4. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 2, 2024
    Copy the full SHA
    515d3b2 View commit details

  5. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 2, 2024
    Copy the full SHA
    7e16111 View commit details

Commits on Aug 6, 2024

  1. [localization-plugin] Improve localized asset construction performanc… 

    …e by 50% (#4862)

* [localization-plugin] Improve localized asset construction performance

* [localization-plugin] Revert reverse iteration

---------

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
    @dmichon-msft
    dmichon-msft and dmichon-msft authored Aug 6, 2024
    Copy the full SHA
    5f75154 View commit details

Commits on Aug 7, 2024

  1. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 7, 2024
    Copy the full SHA
    eecdda2 View commit details

  2. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 7, 2024
    Copy the full SHA
    479a8f8 View commit details

Commits on Aug 8, 2024

  1. Extract LookupByPath -> @rushstack/lookup-by-path (#4868) 

    * Extract LookupByPath -> @rushstack/path-trie

* Update readme

* Revert name to LookupByPath

---------

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
    @dmichon-msft
    dmichon-msft and dmichon-msft authored Aug 8, 2024
    Copy the full SHA
    886111d View commit details

  2. [rush] Fix bundling of rush-sdk. (#4870) 

    * Fix bundling of rush-sdk.

* Make the next release of Rush a PATCH release.
    @iclanton
    iclanton authored Aug 8, 2024
    Copy the full SHA
    8035cd4 View commit details

  3. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    4db95ce View commit details

  4. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    d9ee929 View commit details

  5. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    3b4c5cc View commit details

  6. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    9a6fcbb View commit details

  7. Incldue a missing dependency in rush-sdk. (#4872)

    @iclanton
    iclanton authored Aug 8, 2024
    Copy the full SHA
    fc81708 View commit details

  8. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    1b23c36 View commit details

  9. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 8, 2024
    Copy the full SHA
    a6e2bd3 View commit details

Commits on Aug 10, 2024

  1. [rush-pnpm] Fix rush-pnpm patch-commit command (#4874) 

    * fix rush-pnpm patch commit

* rush change

* Update common/changes/@microsoft/rush/fix-pnpm-patch_2024-08-09-10-38.json

Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>

---------

Co-authored-by: qun <L-Qun@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
    @L-Qun @iclanton
    3 people authored Aug 10, 2024
    Copy the full SHA
    fceee8e View commit details

  2. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 10, 2024
    Copy the full SHA
    2214b93 View commit details

  3. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 10, 2024
    Copy the full SHA
    9f01b5b View commit details

Commits on Aug 11, 2024

  1. Put pnpm patches back in common/pnpm-patches when subspaces are not e… 

    …nabled. (#4876)
    @iclanton
    iclanton authored Aug 11, 2024
    Copy the full SHA
    2909352 View commit details

  2. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 11, 2024
    Copy the full SHA
    0a43a60 View commit details

  3. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 11, 2024
    Copy the full SHA
    253cb78 View commit details

Commits on Aug 12, 2024

  1. Update the .loc.json schema to allow for string names taht include th… 

    …e '$' character. (#4879)
    @iclanton
    iclanton authored Aug 12, 2024
    Copy the full SHA
    3bcf141 View commit details

  2. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 12, 2024
    Copy the full SHA
    e71f730 View commit details

  3. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 12, 2024
    Copy the full SHA
    27837b6 View commit details

Commits on Aug 13, 2024

  1. [eslint-config] Update TypeScript/ESLint Utilities and Refactor Linti… 

    …ng (#4883)

* Bump the version of eslint utils consumed by Rushstack

* Update lint rules for back compat

* Update eslint tests for compatibility

* Bump cyclic versions and rush update

* Lint fix

* Refactor and cleanup of linters

* Bump peer dependency of eslint config package to consume 8.57.0 or greater

* Rush change

* Fix install issues

* Fix install

* Fix readme

* Drop Node 16 support

* Add eslint 8.57.0 to legacy

* Rush update

* PR feedback

* Update user-danade-BumpEslintUtils_2024-08-13-00-25.json

* Empty change to trigger PR check analysis
    @D4N14L
    D4N14L authored Aug 13, 2024
    Copy the full SHA
    20ea8b3 View commit details

  2. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 13, 2024
    Copy the full SHA
    1ae4049 View commit details

  3. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 13, 2024
    Copy the full SHA
    97c0858 View commit details

Commits on Aug 14, 2024

  1. [ts-command-line] Fixes a typo in the README (#4887)

    @bomberstudios
    bomberstudios authored Aug 14, 2024
    Copy the full SHA
    8d69f29 View commit details

  2. [heft-lint-plugin] Add ESLint and TSLint fixer support (#4886) 

    * Nit: docs and cleanup

* Add fix functionality to tslint

* Add support for --fix in ESLint

* Rush change

* Update heft-plugins/heft-lint-plugin/src/Eslint.ts

Co-authored-by: David Michon <dmichon@microsoft.com>

* Update heft-plugins/heft-lint-plugin/src/Eslint.ts

---------

Co-authored-by: David Michon <dmichon@microsoft.com>
    @D4N14L @dmichon-msft
    D4N14L and dmichon-msft authored Aug 14, 2024
    Copy the full SHA
    01173c3 View commit details

  3. [eslint-plugin] Add new import-related rules to the ESLint plugin (#4889 

    )

* Add new eslint rules

* Consume new eslint rules in Rushstack

* Update to newer eslint

* Fix lint issues

* Disable fixes when running in production mode

* Rush change
    @D4N14L
    D4N14L authored Aug 14, 2024
    Copy the full SHA
    0381a02 View commit details

  4. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 14, 2024
    Copy the full SHA
    0350196 View commit details

  5. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 14, 2024
    Copy the full SHA
    8b2024b View commit details

Commits on Aug 15, 2024

  1. [workspace-resolve-plugin] Create plugin for more efficient resolutio… 

    …n when repo structure is known (#4880)

* [workspace-resolve-plugin] Create plugin

* Fixup lint

* Update readme

* Fix cross-platform

* Address PR feedback

---------

Co-authored-by: David Michon <dmichon-msft@users.noreply.github.com>
    @dmichon-msft
    dmichon-msft and dmichon-msft authored Aug 15, 2024
    Copy the full SHA
    0295c11 View commit details

Commits on Aug 16, 2024

  1. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 16, 2024
    Copy the full SHA
    88eb085 View commit details

  2. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 16, 2024
    Copy the full SHA
    9370024 View commit details

  3. [rush-lib] Fix PreferredVersions being ignored when projects have o… 

    …verlapping dependencies (#4835)

* Prioritize explicit preferredVersions over implicit ones

* Add tests

* Add changelog

* Address feedback: foreach() function -> for...of loop

* Fix CI failures

---------

Co-authored-by: ace-n-msft <ace-n-msft@users.noreply.github.com>
    @ace-n-msft
    ace-n-msft and ace-n-msft authored Aug 16, 2024
    Copy the full SHA
    fdc0cd4 View commit details

Commits on Aug 19, 2024

  1. Update changelogs [skip ci]

    @rushbot
    rushbot committed Aug 19, 2024
    Copy the full SHA
    922ef4c View commit details

  2. Bump versions [skip ci]

    @rushbot
    rushbot committed Aug 19, 2024
    Copy the full SHA
    4fcd163 View commit details

  3. [rush-lib] prevent workspace dependencies in decoupledLocalDependenci… 

    …es (#4853)

* prevent decoupled workspace dependencies

* Rush change

* Update common/changes/@microsoft/rush/jmaher-prevent-decoupled-workspace-deps_2024-07-30-15-46.json

Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>

* Update libraries/rush-lib/src/logic/installManager/WorkspaceInstallManager.ts

Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>

* PR Feedback

---------

Co-authored-by: James Maher <jamesmaher-dd@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
    @jamesmaher-dd @iclanton
    3 people authored Aug 19, 2024
    Copy the full SHA
    f4a218d View commit details

  4. Make the next release of Rush a minor bump.

    @iclanton
    iclanton authored Aug 19, 2024
    Copy the full SHA
    01cbfb9 View commit details

Commits on Aug 21, 2024

  1. Fix a test. (#4895)

    @iclanton
    iclanton authored Aug 21, 2024
    Copy the full SHA
    2f08f7b View commit details

  2. [typings-generator] Add some options to typings generation and introd… 

    …uce a Heft plugin for generating loc file typings. (#4894)

* Include an option for a documentation comment for typings default exports.

* Add options to parseAndGenerateTypings return.

* Include a inferDefaultExportInterfaceNameFromFilename option for TypingsGenerator.

* Add a heft plugin for generating localization file tyings.

* Clean up inferred exports names.

* Fix an issue and leave a note.

* Update Readme.

* Rename getVerbose to getVerboseOutput.

* General updates and cleanup to make the change not breaking.

* Introduce a test for StringValuesTypingsGenerator.

* Rush change.

* Code cleanup.

* Random code cleanup in API Extractor.

* Add a Text.splitByNewLines function to NCL.

* Code cleanup.

* Add slashNormalizedBuildFolderPath property to HeftConfiguration.

* Tweak schema.

* Add a test case for the loc typings generator plugin.

* Work around an API Extractor issue.
    @iclanton
    iclanton authored Aug 21, 2024
    Copy the full SHA
    506e6a5 View commit details
Showing 1,042 changed files with 141,232 additions and 11,687 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -9,19 +9,20 @@ on:
jobs:
build:
strategy:
fail-fast: false
matrix:
include:
- NodeVersion: 16.20.x
NodeVersionDisplayName: 16
OS: ubuntu-latest
- NodeVersion: 18.18.x
- NodeVersion: 18.20.x
NodeVersionDisplayName: 18
OS: ubuntu-latest
- NodeVersion: 20.9.x
- NodeVersion: 20.18.x
NodeVersionDisplayName: 20
OS: ubuntu-latest
- NodeVersion: 18.18.x
NodeVersionDisplayName: 18
- NodeVersion: 22.12.x
NodeVersionDisplayName: 22
OS: ubuntu-latest
- NodeVersion: 22.12.x
NodeVersionDisplayName: 22
OS: windows-latest
name: Node.js v${{ matrix.NodeVersionDisplayName }} (${{ matrix.OS }})
runs-on: ${{ matrix.OS }}
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -36,6 +36,7 @@ build/Release/

# Dependency directories
node_modules/
**/.storybook/node_modules
jspm_packages/

# TypeScript cache
3 changes: 2 additions & 1 deletion .vscode/launch.json
View file
Original file line number Diff line number Diff line change
@@ -68,7 +68,8 @@
"name": "Attach",
"type": "node",
"request": "attach",
"port": 9229
"port": 9229,
"outFiles": [],
},
{
"name": "Launch Rush Extension",
Loading