Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Types for promptflow-evals evaluator classes #3201

Open
pamelafox opened this issue May 10, 2024 · 2 comments
Open

[BUG] Types for promptflow-evals evaluator classes #3201

pamelafox opened this issue May 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working promptflow-evals

Comments

@pamelafox
Copy link
Member

Describe the bug

The type for config is listed as AzureOpenAIModelConfiguration:
https://github.com/microsoft/promptflow/blob/main/src/promptflow-evals/promptflow/evals/evaluators/_relevance/_relevance.py#L19

However, my hope is to also use OpenAIModelConfiguration with it, and my guess is that it's not intentionally set to Azure only. Can that type be a union or the base class?

@pamelafox pamelafox added the bug Something isn't working label May 10, 2024
Copy link

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Jun 10, 2024
@pamelafox
Copy link
Member Author

I don't believe any more input is needed from me. (The stalebot in this repo seems to be tuned to respond really quickly to perceived stalneness, btw).

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working promptflow-evals
Projects
None yet
Development

No branches or pull requests

4 participants