fix(expect): properly handle custom asymmetric matcher regression #35149
+107
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return matcher.call(target, ...args); | ||
| if (!testInfo) { | ||
| const matcherResult = matcher.call(target, ...args); | ||
| clearMatcherCallContext(); |
There was a problem hiding this comment.
Can there be an async asymmetric matcher? If there can be we are in trouble!
This comment has been minimized.
This comment has been minimized.
agg23
force-pushed
the
asymmetric-matcher-bad-error-fix
branch
from
f1d47bc to
5604645
Compare
pavelfeldman
approved these changes
Mar 12, 2025
Test results for "tests 1"4 flaky38731 passed, 807 skipped Merge workflow run. |
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35138. #34620 failed to take into consideration multiple asymmetric matchers running in a given
expectexpression, and was a bit aggressive in cleaning it up.