Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/playwright
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.46.0
Choose a base ref
...
head repository: microsoft/playwright
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1c861cfa7a6caf3c5b798786b1e6298c4f3cf31
Choose a head ref
  • 10 commits
  • 36 files changed
  • 5 contributors

Commits on Aug 6, 2024

  1. cherry-pick(#32015): docs(release-notes): fix typo in .NET release notes

    mxschmitt committed Aug 6, 2024
    Copy the full SHA
    5e68061 View commit details

Commits on Aug 8, 2024

  1. cherry-pick(#32066): fix(types): revert type changes made to support …

    …TS 5.5 (#32080)
    
    Regressed in #31532. The TS5.5 changes broke chaining of `extend`s where
    the first `extend` did not specify any type arguments.
    
    Fixes #32056.
    dgozman authored Aug 8, 2024
    Copy the full SHA
    30684a7 View commit details

Commits on Aug 14, 2024

  1. cherry-pick(#32155): fix(client-certificates): when server does tls r…

    …enegotiation
    
    Certain https servers like Microsoft IIS aka. TLS servers do the TLS
    renegotiation after the TLS handshake. This ends up in two
    `'secureConnect'` events due to an upstream Node.js bug:
    nodejs/node#54362
    
    Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as
    well.
    
    Relates #32004
    mxschmitt committed Aug 14, 2024
    Copy the full SHA
    bd13da4 View commit details

Commits on Aug 15, 2024

  1. cherry-pick(#32163): fix(client-certificates): stall on tls handshake…

    … errors
    
    Extracted from #32158.
    mxschmitt committed Aug 15, 2024
    Copy the full SHA
    d78ae01 View commit details
  2. cherry-pick(#32094): fix(test runner): run project dependencies of `-…

    …-only-changed` test files (#32172)
    
    Closes #32070. We were
    applying `additionalFileMatcher` not just to `filteredProjectSuites`,
    but also to `projectSuites`. `projectSuites` is where we take dependency
    projects from, though - so `--only-changed` led to empty dependency
    projects, resulting in the reported bug.
        
    The fix is to only apply `additionalFileMatcher` on
    `filteredProjectSuites`.
    Skn0tt authored Aug 15, 2024
    Copy the full SHA
    7cf7aec View commit details
  3. cherry-pick(#32164): docs: release video and trace viewer video (#32173)

    This PR cherry-picks the following commits:
    
    - f927495
    
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    playwrightmachine and github-actions[bot] authored Aug 15, 2024
    Copy the full SHA
    b2d6a09 View commit details

Commits on Aug 16, 2024

  1. cherry-pick(#32189): fix(only-changed): show nice error message about…

    … shallow clones (#32190)
    
    This PR cherry-picks the following commits:
    
    - 06ffdd6
    
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    playwrightmachine and github-actions[bot] authored Aug 16, 2024
    Copy the full SHA
    301f179 View commit details
  2. cherry-pick(#32192): chore: generate self-signed certificates for soc…

    …ks proxy
    mxschmitt committed Aug 16, 2024
    Copy the full SHA
    57c3240 View commit details
  3. chore: mark v1.46.1 (#32194)

    mxschmitt authored Aug 16, 2024
    Copy the full SHA
    20b0788 View commit details
  4. cherry-pick(#32021): test: fix failing client-certificate tests

    mxschmitt committed Aug 16, 2024
    Copy the full SHA
    e1c861c View commit details
Showing with 406 additions and 176 deletions.
  1. +0 −1 docs/src/release-notes-csharp.md
  2. +7 −1 docs/src/release-notes-js.md
  3. +1 −1 docs/src/trace-viewer-intro-js.md
  4. +5 −5 docs/src/trace-viewer.md
  5. +34 −34 package-lock.json
  6. +1 −1 package.json
  7. +2 −2 packages/playwright-browser-chromium/package.json
  8. +2 −2 packages/playwright-browser-firefox/package.json
  9. +2 −2 packages/playwright-browser-webkit/package.json
  10. +2 −2 packages/playwright-chromium/package.json
  11. +0 −11 packages/playwright-core/bin/socks-certs/README.md
  12. +0 −19 packages/playwright-core/bin/socks-certs/cert.pem
  13. +0 −28 packages/playwright-core/bin/socks-certs/key.pem
  14. +1 −1 packages/playwright-core/package.json
  15. +16 −23 packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
  16. +168 −0 packages/playwright-core/src/utils/crypto.ts
  17. +5 −3 packages/playwright-core/src/utils/happy-eyeballs.ts
  18. +3 −3 packages/playwright-ct-core/package.json
  19. +2 −2 packages/playwright-ct-react/package.json
  20. +2 −2 packages/playwright-ct-react17/package.json
  21. +2 −2 packages/playwright-ct-solid/package.json
  22. +2 −2 packages/playwright-ct-svelte/package.json
  23. +2 −2 packages/playwright-ct-vue/package.json
  24. +2 −2 packages/playwright-ct-vue2/package.json
  25. +2 −2 packages/playwright-firefox/package.json
  26. +2 −2 packages/playwright-test/package.json
  27. +2 −2 packages/playwright-webkit/package.json
  28. +2 −2 packages/playwright/package.json
  29. +9 −7 packages/playwright/src/runner/loadUtils.ts
  30. +12 −0 packages/playwright/src/runner/vcs.ts
  31. +2 −2 packages/playwright/types/test.d.ts
  32. +45 −2 tests/library/client-certificates.spec.ts
  33. +1 −1 tests/library/global-fetch.spec.ts
  34. +49 −0 tests/playwright-test/only-changed.spec.ts
  35. +17 −3 tests/playwright-test/types.spec.ts
  36. +2 −2 utils/generate_types/overrides-test.d.ts
1 change: 0 additions & 1 deletion docs/src/release-notes-csharp.md
Original file line number Diff line number Diff line change
@@ -156,7 +156,6 @@ await Page.RemoveLocatorHandlerAsync(locator);
**Miscellaneous options**

- New method [`method: FormData.append`] allows to specify repeating fields with the same name in [`Multipart`](./api/class-apirequestcontext#api-request-context-fetch-option-multipart) option in `APIRequestContext.FetchAsync()`:
- ```
```csharp
var formData = Context.APIRequest.CreateFormData();
formData.Append("file", new FilePayload()
8 changes: 7 additions & 1 deletion docs/src/release-notes-js.md
Original file line number Diff line number Diff line change
@@ -8,9 +8,15 @@ import LiteYouTube from '@site/src/components/LiteYouTube';

## Version 1.46

<LiteYouTube
id="tQo7w-QQBsI"
title="Playwright 1.46"
/>


### TLS Client Certificates

Playwright now allows to supply client-side certificates, so that server can verify them, as specified by TLS Client Authentication.
Playwright now allows you to supply client-side certificates, so that server can verify them, as specified by TLS Client Authentication.

The following snippet sets up a client certificate for `https://example.com`:

2 changes: 1 addition & 1 deletion docs/src/trace-viewer-intro-js.md
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ Playwright Trace Viewer is a GUI tool that lets you explore recorded Playwright
- [How to open and view the trace](/trace-viewer-intro.md#opening-the-trace)

<LiteYouTube
id="lfxjs--9ZQs"
id="yP6AnTxC34s"
title="Viewing Playwright Traces"
/>

10 changes: 5 additions & 5 deletions docs/src/trace-viewer.md
Original file line number Diff line number Diff line change
@@ -13,14 +13,14 @@ Playwright Trace Viewer is a GUI tool that helps you explore recorded Playwright
* langs: js

<LiteYouTube
id="lfxjs--9ZQs"
id="yP6AnTxC34s"
title="Viewing Playwright Traces"
/>

## Trace Viewer features
### Actions

In the Actions tab you can see what locator was used for every action and how long each one took to run. Hover over each action of your test and visually see the change in the DOM snapshot. Go back and forward in time and click an action to inspect and debug. Use the Before and After tabs to visually see what happened before and after the action.
In the Actions tab you can see what locator was used for every action and how long each one took to run. Hover over each action of your test and visually see the change in the DOM snapshot. Go back and forward in time and click an action to inspect and debug. Use the Before and After tabs to visually see what happened before and after the action.

![actions tab in trace viewer](https://github.com/microsoft/playwright/assets/13063165/948b65cd-f0fd-4c7f-8e53-2c632b5a07f1)

@@ -31,7 +31,7 @@ In the Actions tab you can see what locator was used for every action and how lo

### Screenshots

When tracing with the [`option: screenshots`] option turned on (default), each trace records a screencast and renders it as a film strip. You can hover over the film strip to see a magnified image of for each action and state which helps you easily find the action you want to inspect.
When tracing with the [`option: screenshots`] option turned on (default), each trace records a screencast and renders it as a film strip. You can hover over the film strip to see a magnified image of for each action and state which helps you easily find the action you want to inspect.

Double click on an action to see the time range for that action. You can use the slider in the timeline to increase the actions selected and these will be shown in the Actions tab and all console logs and network logs will be filtered to only show the logs for the actions selected.

@@ -393,7 +393,7 @@ public class ExampleTest : PageTest
[TearDown]
public async Task TearDown()
{
var failed = TestContext.CurrentContext.Result.Outcome == NUnit.Framework.Interfaces.ResultState.Error
var failed = TestContext.CurrentContext.Result.Outcome == NUnit.Framework.Interfaces.ResultState.Error
|| TestContext.CurrentContext.Result.Outcome == NUnit.Framework.Interfaces.ResultState.Failure;

await Context.Tracing.StopAsync(new()
@@ -402,7 +402,7 @@ public class ExampleTest : PageTest
TestContext.CurrentContext.WorkDirectory,
"playwright-traces",
$"{TestContext.CurrentContext.Test.ClassName}.{TestContext.CurrentContext.Test.Name}.zip"
) : null,
) : null,
});
}

68 changes: 34 additions & 34 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "playwright-internal",
"private": true,
"version": "1.46.0",
"version": "1.46.1",
"description": "A high-level API to automate web browsers",
"repository": {
"type": "git",
4 changes: 2 additions & 2 deletions packages/playwright-browser-chromium/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@playwright/browser-chromium",
"version": "1.46.0",
"version": "1.46.1",
"description": "Playwright package that automatically installs Chromium",
"repository": {
"type": "git",
@@ -27,6 +27,6 @@
"install": "node install.js"
},
"dependencies": {
"playwright-core": "1.46.0"
"playwright-core": "1.46.1"
}
}
4 changes: 2 additions & 2 deletions packages/playwright-browser-firefox/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@playwright/browser-firefox",
"version": "1.46.0",
"version": "1.46.1",
"description": "Playwright package that automatically installs Firefox",
"repository": {
"type": "git",
@@ -27,6 +27,6 @@
"install": "node install.js"
},
"dependencies": {
"playwright-core": "1.46.0"
"playwright-core": "1.46.1"
}
}
4 changes: 2 additions & 2 deletions packages/playwright-browser-webkit/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@playwright/browser-webkit",
"version": "1.46.0",
"version": "1.46.1",
"description": "Playwright package that automatically installs WebKit",
"repository": {
"type": "git",
@@ -27,6 +27,6 @@
"install": "node install.js"
},
"dependencies": {
"playwright-core": "1.46.0"
"playwright-core": "1.46.1"
}
}
4 changes: 2 additions & 2 deletions packages/playwright-chromium/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "playwright-chromium",
"version": "1.46.0",
"version": "1.46.1",
"description": "A high-level API to automate Chromium",
"repository": {
"type": "git",
@@ -30,6 +30,6 @@
"install": "node install.js"
},
"dependencies": {
"playwright-core": "1.46.0"
"playwright-core": "1.46.1"
}
}
11 changes: 0 additions & 11 deletions packages/playwright-core/bin/socks-certs/README.md

This file was deleted.

Loading