Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] onnxruntime with tag 1.20.* build failed on Windows after VS upgrade to 17.13.* #23911

Closed
mslichao opened this issue Mar 6, 2025 · 2 comments
Labels
build build issues; typically submitted using template platform:windows issues related to the Windows platform

Comments

@mslichao
Copy link
Member

mslichao commented Mar 6, 2025

Describe the issue

https://devblogs.microsoft.com/cppblog/whats-new-for-c-developers-in-visual-studio-2022-17-13/
VS 17.13.* have a breaking change:

We’ve improved the build throughput of , , , and by not including all of . For the same reason, we’ve moved system_clock, high_resolution_clock, and chrono_literals from a commonly-included internal header to . This has source-breaking impact. If you see compiler errors complaining that it doesn’t recognize chrono types like system_clock or UDLs like 1729ms, you need to include specifically, instead of assuming that headers like will drag it in.

This breaking change caused the https://github.com/microsoft/onnxruntime/blob/v1.20.2/include/onnxruntime/core/platform/ort_mutex.h build failed.

Add #include <chrono> can fix this issue, can we patch the 1.20.* to fix this build failure?

Urgency

No response

Target platform

Windows

Build script

Default build

Error / output

system_clock not defined

Visual Studio Version

17.13.*

GCC / Compiler Version

No response

@mslichao mslichao added the build build issues; typically submitted using template label Mar 6, 2025
@github-actions github-actions bot added the platform:windows issues related to the Windows platform label Mar 6, 2025
@snnn
Copy link
Member

snnn commented Mar 6, 2025

We will publish a new release soon, and it will not have this file.

@snnn
Copy link
Member

snnn commented Mar 6, 2025

See #23885

@snnn snnn closed this as completed Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build issues; typically submitted using template platform:windows issues related to the Windows platform
Projects
None yet
Development

No branches or pull requests

2 participants