Unify data storage #4148
Merged
Unify data storage #4148
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Feb 22, 2024
nibanks
reviewed
Feb 23, 2024
scripts/secnetperf.ps1
Outdated
Comment on lines
200
to
201
| # Create file to persist full latency curve data: | ||
| New-Item -ItemType File -Name "full-latency-curve.txt" |
There was a problem hiding this comment.
This is unnecessary. secnetperf will create the file (it does fopen("w")).
nibanks
reviewed
Feb 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
ProjectsByJackHe
force-pushed
the
jackhe/database-latency
branch
from
e2982f6 to
07eee4a
Compare
|
https://github.com/microsoft/netperf/actions/runs/8027444653/job/21932394979 most recent run, where all the latency curves are successfully produced / uploaded. |
nibanks
reviewed
Feb 24, 2024
nibanks
reviewed
Feb 24, 2024
Comment on lines
+117
to
+118
| # Create intermediary files. | ||
| New-Item -ItemType File -Name "latency.txt" |
There was a problem hiding this comment.
I think this is unnecessary now, but we can remove in a future PR.
nibanks
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to unify everything data-storage related.
It will accommodate the next stage in netperf development where we have dynamically changing test environments.
In addition, this PR will persist the full latency txt curves, and netperf will handle parsing/condensing/saving it.
Testing
CI
Documentation
N/A