Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Threat Model doc #4135

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add a Threat Model doc #4135

merged 1 commit into from
Feb 14, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Feb 14, 2024

Description

Documentation of the threat model for MsQuic.

Testing

N/A

Documentation

This is new documentation.

@nibanks nibanks requested a review from a team as a code owner February 14, 2024 16:54
Copy link
Contributor

@ProjectsByJackHe ProjectsByJackHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@qzhuyan
Copy link
Contributor

qzhuyan commented Feb 14, 2024

maybe the dynamic linked libraries should also be mentioned in this doc?

@nibanks
Copy link
Member Author

nibanks commented Feb 14, 2024

maybe the dynamic linked libraries should also be mentioned in this doc?

Are you asking if we should specifically list out the libraries msquic.dll / libmsquic.so depends on?

@qzhuyan
Copy link
Contributor

qzhuyan commented Feb 14, 2024

maybe the dynamic linked libraries should also be mentioned in this doc?

Are you asking if we should specifically list out the libraries msquic.dll / libmsquic.so depends on?

Not sure if it is in this scope,
Maybe the reader need to be aware of which library the msquic links to, just like a reminder.

@nibanks
Copy link
Member Author

nibanks commented Feb 14, 2024

maybe the dynamic linked libraries should also be mentioned in this doc?

Are you asking if we should specifically list out the libraries msquic.dll / libmsquic.so depends on?

Not sure if it is in this scope, Maybe the reader need to be aware of which library the msquic links to, just like a reminder.

I'm not opposed to listing out dependencies (though probably in a follow up PR). I just wanted to confirm I understood your comment.

@nibanks nibanks merged commit 6d5e84b into main Feb 14, 2024
343 of 345 checks passed
@nibanks nibanks deleted the nibanks/threat-model branch February 14, 2024 21:08
@nibanks
Copy link
Member Author

nibanks commented Feb 14, 2024

We can follow up with a dependency list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants