Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Updated serialization and deserialization of enum collection #144

Merged
merged 1 commit into from
May 21, 2024

Conversation

filipnavara
Copy link
Contributor

Updated serialization and deserialization of enum collection to remove LINQ to reduce NativeAOT output size.

This removes 60 MB of output size on our app.

@filipnavara filipnavara requested a review from a team as a code owner May 21, 2024 14:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…e LINQ to reduce NativeAOT output size
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!

@baywet baywet enabled auto-merge May 21, 2024 16:18
@baywet
Copy link
Member

baywet commented May 21, 2024

Updated serialization and deserialization of enum collection to remove LINQ to reduce NativeAOT output size.

This removes 60 MB of output size on our app.

Are those 60MB in addition to the 30 in #143 or in total?

@filipnavara
Copy link
Contributor Author

Are those 60MB in addition to the 30 in #143 or in total?

I didn’t make the previous measurement. In our case the app crashed all the tools previously so there was no output size to measure. This is additional 60MB for our usage of the Graph SDK (ie. not including any savings from the previous PR).

@baywet baywet merged commit 83982a5 into microsoft:main May 21, 2024
7 checks passed
@kasperk81
Copy link
Contributor

#148 for complete removal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants