-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow one value on certain headers #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @edouardpoitras. Really do appreciate it.
Apart from the comments, can you also please update the following before we merge this?
- Bump the version at https://github.com/microsoft/kiota-abstractions-dotnet/blob/main/src/Microsoft.Kiota.Abstractions.csproj#L16
- Update the Changelog file
Thanks for the contribution!
See more information about how fields should be folded. Looking at the other metadata fields it sounds to me that the following fields should also be added to this list:
|
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
- Now overrides previous values - Fixed tests - Updated changelog - Bumped version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. @andrueastman for final review and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @edouardpoitras
This is related to the bug I submitted on msgraph-sdk-dotnet: microsoftgraph/msgraph-sdk-dotnet#1951