Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow one value on certain headers #93

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

edouardpoitras
Copy link
Contributor

This is related to the bug I submitted on msgraph-sdk-dotnet: microsoftgraph/msgraph-sdk-dotnet#1951

src/RequestHeaders.cs Outdated Show resolved Hide resolved
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution here @edouardpoitras. Really do appreciate it.

Apart from the comments, can you also please update the following before we merge this?

src/RequestHeaders.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Jun 13, 2023

Thanks for the contribution!
Aside from Andrew's comments, I wanted to provide more context here Content-Type is a singleton field

Although Content-Type is defined as a singleton field, it is sometimes incorrectly generated multiple times, resulting in a combined field value that appears to be a list

See more information about how fields should be folded.

Looking at the other metadata fields it sounds to me that the following fields should also be added to this list:

  • Content-Encoding
  • Content-Length
  • Content-Location (only applies to responses, maybe skipped)
  • Last-Modified (same)

edouardpoitras and others added 2 commits June 13, 2023 13:41
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
- Now overrides previous values
- Fixed tests
- Updated changelog
- Bumped version
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. @andrueastman for final review and merge.

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @edouardpoitras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants