Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to std-uritemplate #123

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Sep 4, 2023

Fix #122

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we solve for the casing issue in the generation

@andreaTP
Copy link
Contributor Author

andreaTP commented Sep 7, 2023

Updated to 0.0.40 (with the improved publishing) and the fix landed in the main repo.
This should be good to go 🙂

@andreaTP
Copy link
Contributor Author

andreaTP commented Sep 18, 2023

Is there anything I can do to help move this forward?
In my understanding, all the bugs have been fixed already.

@baywet
Copy link
Member

baywet commented Sep 18, 2023

@andreaTP I think one of the last thing that's missing for std uri template is for it to be digitally signed. But maybe that's only a requirement for Microsoft owned assemblies. It's a bit of a gray area. Note: we also depend on OpenTelemetry which is not digitally sign.
@andrueastman are you able to provide more details about the potentially digital signature requirements in dotnet?

Also having another look at this thread is seems that besides digital signature, ownership of the package is still an issue. I just created an organization Std.UriTemplate, to which I've sent you an invite.
If you could:

  1. accept the invite
  2. transfer the package to the org
  3. update the token you setup for releasing to be an organization package instead of a personal one (otherwise the next version will go back to your personal account)

(as a general rule of thumb this is probably something we should follow for all package feeds as a reliability approach)

@andreaTP
Copy link
Contributor Author

Thanks @baywet for helping out here!
Looks like packages can have co-owners and I can keep the token, let me know if this is enough.

image

@baywet
Copy link
Member

baywet commented Sep 18, 2023

I'd advocate for making the organization only as owner of the package to fully address the concern voiced by the user.

@andreaTP
Copy link
Contributor Author

Ok, completely open about this, done 👍

baywet
baywet previously approved these changes Sep 19, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM. @andrueastman for final review and to provide input on digital signature.

@andreaTP
Copy link
Contributor Author

andreaTP commented Sep 19, 2023

Thanks @baywet for checking everything!
Please note that we are on-par with the OpenTelemetry libraries and this is an interesting assessment done on their side.

Additionally, we are not making the current situation worse as Tavis doesn't have a digital signature as well IIRC.

@andrueastman
Copy link
Member

I just created this PR to address the deterministic builds issue in the generated package for source link. std-uritemplate/std-uritemplate#72 otherwise this looks good to me.

Additionally, we are not making the current situation worse as Tavis doesn't have a digital signature as well IIRC.

This is true, the Tavis dlls are not signed now and moving forward would be keeping the situation as is. Failing to have a Strong name is what can be blocking for users as some runtimes won't run/build if a dependency isn't strongly named (which is addressed).

Like the challenge for OpenTelemetry, the issue would be figuring out certificate management for the signing of the package as at the moment, our current packages are signed using a signing service available in ADO which makes it easier in this end.
As this wouldn't really be a regression and we can probably move forward with the change and figure out the best methods for certificate management and sort this out separately (as signing the package with MSFT certs would be confusing for the end user).

baywet
baywet previously approved these changes Sep 20, 2023
andrueastman
andrueastman previously approved these changes Sep 21, 2023
@baywet
Copy link
Member

baywet commented Sep 21, 2023

@andrueastman can you push a changelog entry and version bump to this PR please? (minor, today)

@andrueastman andrueastman dismissed stale reviews from baywet and themself via 667a6d6 September 21, 2023 12:46
@baywet baywet merged commit f557db3 into microsoft:main Sep 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swap tavis uri template for std uri template
3 participants