-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-positioning): update writeArrowUpdates to correctly resolve arrow positioning #33260
Merged
mainframev
merged 8 commits into
microsoft:master
from
mainframev:fix/react-positioning-and-arrow
Nov 14, 2024
Merged
fix(react-positioning): update writeArrowUpdates to correctly resolve arrow positioning #33260
mainframev
merged 8 commits into
microsoft:master
from
mainframev:fix/react-positioning-and-arrow
Nov 14, 2024
+102
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
fabricteam
reviewed
Nov 12, 2024
change/@fluentui-react-positioning-a171cb79-b220-449e-83a3-440d479bdc84.json
Show resolved
Hide resolved
packages/react-components/react-positioning/src/utils/writeArrowUpdates.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-positioning/src/utils/writeArrowUpdates.ts
Outdated
Show resolved
Hide resolved
...omponents/react-tooltip/stories/src/Tooltip/TooltipWithArrowAndFallbackPositions.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are valid visual regressions, please address them first.
f42cdf4
to
5384835
Compare
packages/react-components/react-positioning/src/utils/writeArrowUpdates.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the story to VR tests. Other than, LGTM 👍
…resolve arrow position
5384835
to
36e9368
Compare
packages/react-components/react-tooltip/stories/src/Tooltip/index.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Nov 13, 2024
Loading status checks…
…dex.stories.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates logic inside
writeArrowUpdates
to correctly apply positioning offsets for X and Y. The story added for demonstration purposes and easier code review and can be dropped after.Previous Behavior
Screen.Recording.2024-11-12.at.16.44.43.mov
New Behavior
Screen.Recording.2024-11-12.at.16.45.35.mov
Related Issue(s)